Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1ED6195BB for ; Tue, 1 Mar 2016 08:25:14 +0000 (UTC) Received: (qmail 29018 invoked by uid 500); 1 Mar 2016 08:25:01 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 28930 invoked by uid 500); 1 Mar 2016 08:25:01 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 28915 invoked by uid 99); 1 Mar 2016 08:25:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Mar 2016 08:25:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6F4331D9C42; Tue, 1 Mar 2016 08:25:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6142961789767237291==" MIME-Version: 1.0 Subject: Re: Review Request 44201: HIVE-13188: Allow users of RetryingThriftClient to close transport From: Amareshwari Sriramadasu To: Amareshwari Sriramadasu , hive Date: Tue, 01 Mar 2016 08:25:00 -0000 Message-ID: <20160301082500.6191.38980@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Amareshwari Sriramadasu X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44201/ X-Sender: Amareshwari Sriramadasu References: <20160301071818.26940.5723@reviews.apache.org> In-Reply-To: <20160301071818.26940.5723@reviews.apache.org> Reply-To: Amareshwari Sriramadasu X-ReviewRequest-Repository: hive-git --===============6142961789767237291== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44201/#review121407 ----------------------------------------------------------- service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java (line 61) Can you update test to call new method introduced? - Amareshwari Sriramadasu On March 1, 2016, 7:18 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44201/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 7:18 a.m.) > > > Review request for hive. > > > Bugs: HIVE-13188 > https://issues.apache.org/jira/browse/HIVE-13188 > > > Repository: hive-git > > > Description > ------- > > RetryingThriftCLIClient opens a TTransport and leaves it open. there should be a way to close that. > > > Diffs > ----- > > service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java a81c600236e6e0f53a484806e559303279244616 > service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3798053a4a2e2b26b97b5accf96d73b58c89fb6e > > Diff: https://reviews.apache.org/r/44201/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > > --===============6142961789767237291==--