hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vaibhav Gumashta <vgumas...@hortonworks.com>
Subject Re: Review Request 45137: HiveServer2: Make ZK config publishing configurable
Date Tue, 22 Mar 2016 20:10:19 GMT


> On March 22, 2016, 6:24 a.m., Thejas Nair wrote:
> > service/src/java/org/apache/hive/service/server/HiveServer2.java, line 257
> > <https://reviews.apache.org/r/45137/diff/1/?file=1309600#file1309600line257>
> >
> >     better to avoid these cosmetic changes that don't seem to improve style compliance

I have the hive compliant style set on my editor and selected the method I changed and applied
the formatting. I'll revert that and limit to specific code changes.


- Vaibhav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45137/#review124741
-----------------------------------------------------------


On March 22, 2016, 12:36 a.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45137/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 12:36 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-13326
>     https://issues.apache.org/jira/browse/HIVE-13326
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-13326
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0f8d67f 
>   jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 1ca77a1 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java ab834b9 
> 
> Diff: https://reviews.apache.org/r/45137/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message