hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thejas Nair <the...@hortonworks.com>
Subject Re: Review Request 45137: HiveServer2: Make ZK config publishing configurable
Date Tue, 22 Mar 2016 06:24:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45137/#review124741
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2020)
<https://reviews.apache.org/r/45137/#comment187399>

    It would be good to be more obvious in the description, by using HiveServer2 instead of
server.



jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java (line 51)
<https://reviews.apache.org/r/45137/#comment187400>

    it would be good to avoid unrelated changes, specially when both before and after state
look OK. It keeps git-blame more useful!



jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java (line 84)
<https://reviews.apache.org/r/45137/#comment187402>

    Can you also print dataStr here ?



service/src/java/org/apache/hive/service/server/HiveServer2.java (line 257)
<https://reviews.apache.org/r/45137/#comment187403>

    better to avoid these cosmetic changes that don't seem to improve style compliance


- Thejas Nair


On March 22, 2016, 12:36 a.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45137/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 12:36 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-13326
>     https://issues.apache.org/jira/browse/HIVE-13326
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-13326
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0f8d67f 
>   jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 1ca77a1 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java ab834b9 
> 
> Diff: https://reviews.apache.org/r/45137/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message