hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aihua Xu <...@cloudera.com>
Subject Re: Review Request 44910: HIVE-13294: AvroSerde leaks the connection in a case when reading schema from a url
Date Wed, 16 Mar 2016 13:19:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44910/#review123868
-----------------------------------------------------------




serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java (line 276)
<https://reviews.apache.org/r/44910/#comment186156>

    nit: typo "//Ignore"



serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java (line 280)
<https://reviews.apache.org/r/44910/#comment186157>

    nit: remove the empty space here


- Aihua Xu


On March 16, 2016, 12:46 p.m., Chaoyu Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44910/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 12:46 p.m.)
> 
> 
> Review request for hive, Aihua Xu, Szehon Ho, and Yongzhi Chen.
> 
> 
> Bugs: HIVE-13294
>     https://issues.apache.org/jira/browse/HIVE-13294
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> AvroSerde leaks the connection in a case when reading schema from url:
> In
> public static Schema determineSchemaOrThrowException
> { ... return AvroSerdeUtils.getSchemaFor(new URL(schemaString).openStream()); ... }
> 
> The opened inputStream is never closed.
> 
> The patch is to close the inputStream (thus the connection) in finally block
> 
> 
> Diffs
> -----
> 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java 08ae6ef 
> 
> Diff: https://reviews.apache.org/r/44910/diff/
> 
> 
> Testing
> -------
> 
> precommit test
> 
> 
> Thanks,
> 
> Chaoyu Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message