hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rajat Khandelwal <rajatgupt...@gmail.com>
Subject Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing
Date Tue, 08 Mar 2016 07:36:31 GMT


> On March 8, 2016, 3:36 a.m., Szehon Ho wrote:
> > serde/if/serde.thrift, line 33
> > <https://reviews.apache.org/r/44453/diff/1/?file=1282939#file1282939line33>
> >
> >     Is this part of the change?

Refer https://issues.apache.org/jira/browse/HIVE-12994?focusedCommentId=15183059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15183059

Please ignore it in my review request, since it's already getting fixed elsewhere.


> On March 8, 2016, 3:36 a.m., Szehon Ho wrote:
> > service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java,
line 1
> > <https://reviews.apache.org/r/44453/diff/1/?file=1282957#file1282957line1>
> >
> >     I dont see where this thrift class is defined or used?  Same for JobTrackerState,
ThriftHive, etc..

I think in master thrift files have changes without corresponding changes reflecting in generated
files. Removed for now.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44453/#review122382
-----------------------------------------------------------


On March 8, 2016, 1:03 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44453/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 1:03 p.m.)
> 
> 
> Review request for hive, Amareshwari Sriramadasu and Puneet Gupta.
> 
> 
> Bugs: HIVE-4570
>     https://issues.apache.org/jira/browse/HIVE-4570
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Currently in Hive Server2, when the query is still executing only the status is set as
STILL_EXECUTING. 
> 
> This issue is to give more information to the user such as progress and running job handles,
if possible.
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java
de66d9efb1cace9d32174e3020920d5e4002dc85 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 32531465cba95de6caa1bd292d489c1582efb942

>   ql/src/java/org/apache/hadoop/hive/ql/TaskStatus.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9

>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java b184b4e554cf3f7a61932195b9b840cf13f3594b

>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe

>   service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc 
>   service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java
a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98 
>   service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930

>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19

>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98

>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d

>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a

>   service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171

> 
> Diff: https://reviews.apache.org/r/44453/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message