hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Review Request 40415: HIVE-11675 make use of file footer PPD API in ETL strategy or separate strategy
Date Mon, 07 Mar 2016 20:11:17 GMT


> On March 7, 2016, 7:27 a.m., Prasanth_J wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java, line
2223
> > <https://reviews.apache.org/r/40415/diff/6/?file=1276199#file1276199line2223>
> >
> >     use ThreadLocal?

Not sure that helps. Also, it's a threadlocal... Remembering the result for some time could
be a good solution in a follow-up, but we assume by default that if the user enables it they
know what they are doing, or pay a small perf penalty


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40415/#review122261
-----------------------------------------------------------


On March 2, 2016, 2:30 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40415/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 2:30 a.m.)
> 
> 
> Review request for hive, Gopal V, Prasanth_J, and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2723dad 
>   metastore/src/java/org/apache/hadoop/hive/metastore/FileFormatProxy.java ec0be2b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java bd4e188

>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java b5c4d1d

>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cb092d1 
>   metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java
1b388aa 
>   orc/src/java/org/apache/orc/impl/InStream.java b1c6de5 
>   ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 9bf9377 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/LocalCache.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetastoreExternalCachesByConf.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java ef76723 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 0ebcd2a 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java fdc7956 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 4fafe8c 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 7a93b54 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java dc71db4 
>   storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java be5e67b

> 
> Diff: https://reviews.apache.org/r/40415/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message