hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rajat Khandelwal <>
Subject Re: Review Request 44146: HIVE-13179: Allow custom HiveConf to be passed to Authentication Providers
Date Thu, 03 Mar 2016 08:18:20 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 3, 2016, 1:48 p.m.)

Review request for hive.

Bugs: HIVE-13179

Repository: hive-git


Right now if I want to create an ldap auth provider, I have to create a hive-site.xml, set
endpoints and other relevant properties there, then instantiate `LdapAuthenticationProviderImpl`,
since inside the constructor, a new HiveConf is constructed. 

A better and more reusable design would be to ask for the conf in the constructor itself.
That will allow an external user to create a HiveConf, set all relevant properties and instantiate
`LdapAuthenticationProviderImpl` with that conf.

Diffs (updated)

  service/src/java/org/apache/hive/service/auth/ 4b95503eb19cf862fb6efa614c9746b477337158

  service/src/java/org/apache/hive/service/auth/ 3dc0aa86e2d4acc9604e27dabb8f683d4cd0705d

  service/src/java/org/apache/hive/service/auth/ 1d4aba2cc37930d87b620815fb317c1977f6e901

  service/src/java/org/apache/hive/service/auth/ fd58081653af1a846394eddd513d94751e0129e2

  service/src/test/org/apache/hive/service/auth/ e5cee37ac72001086323c94392274fb86f4307ef

  service/src/test/org/apache/hive/service/auth/ 5e91a0eb8a1bfc8a8d6e6774b195de9731035bdd




Rajat Khandelwal

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message