hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Amareshwari Sriramadasu <amareshw...@apache.org>
Subject Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config
Date Thu, 03 Mar 2016 06:30:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44172/#review121807
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 139)
<https://reviews.apache.org/r/44172/#comment183642>

    Required any more?



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 3389)
<https://reviews.apache.org/r/44172/#comment183641>

    We should have a wrapper for set/getQueryString which will encode with URLencoder. And
call callers should change to call this.


- Amareshwari Sriramadasu


On March 2, 2016, 6:01 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44172/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 6:01 a.m.)
> 
> 
> Review request for hive and Alan Gates.
> 
> 
> Bugs: HIVE-11483
>     https://issues.apache.org/jira/browse/HIVE-11483
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> We have seen some queries in production where some of the literals passed in the query
have control characters, which result in exception when query string is set in the job xml.
> 
> Proposing a solution to encode the query string in configuration and provide getters
decoded string.
> 
> Here is a commit in a forked repo : https://github.com/InMobi/hive/commit/2faf5761191fa3103a0d779fde584d494ed75bf5
> 
> Suggestions are welcome on the solution.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2723dadd76418f23b6e6358d21304e3312ef1cbd

>   common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java 365d5005d2a1f240b12bb4e9f9a920b3db4d32ba

> 
> Diff: https://reviews.apache.org/r/44172/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message