hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Amareshwari Sriramadasu <amareshw...@apache.org>
Subject Re: Review Request 18182: HIVE-5370. format_number udf should take user specifed format as argument
Date Thu, 03 Mar 2016 06:19:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18182/
-----------------------------------------------------------

(Updated March 3, 2016, 6:19 a.m.)


Review request for hive, Ashutosh Chauhan, Alan Gates, and Navis Ryu.


Changes
-------

Review comments incorporated


Bugs: HIVE-5370
    https://issues.apache.org/jira/browse/HIVE-5370


Repository: hive-git


Description
-------

Added the format as optional argument.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java 71ca8f2 
  ql/src/test/queries/clientnegative/udf_format_number_wrong6.q e5b11b9 
  ql/src/test/queries/clientpositive/udf_format_number.q 28f087d 
  ql/src/test/results/clientnegative/udf_format_number_wrong1.q.out c3cb800 
  ql/src/test/results/clientnegative/udf_format_number_wrong2.q.out 1fe8a7c 
  ql/src/test/results/clientnegative/udf_format_number_wrong4.q.out 3953ef1 
  ql/src/test/results/clientnegative/udf_format_number_wrong6.q.out d51991f 
  ql/src/test/results/clientpositive/udf_format_number.q.out 4a2c80d 

Diff: https://reviews.apache.org/r/18182/diff/


Testing
-------

Unit tested


Thanks,

Amareshwari Sriramadasu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message