hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akshay Goyal <akshaygoyal2...@gmail.com>
Subject Re: Review Request 42134: More information to user on GetOperationStatus in Hive Server2 when query is still executing
Date Wed, 02 Mar 2016 11:09:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42134/
-----------------------------------------------------------

(Updated March 2, 2016, 11:09 a.m.)


Review request for hive and Amareshwari Sriramadasu.


Changes
-------

review comments addressed.


Bugs: HIVE-4570
    https://issues.apache.org/jira/browse/HIVE-4570


Repository: hive-git


Description
-------

Driver maintains list of running and runnable tasks although that info is not exposed outside.
It's kept locally in the driver's execute method. We can add Driver.getTaskStatuses() to return
status on all tasks (both running and runnable). Similarly, start and completion times for
operations.

Proposed changes are :

struct TGetOperationStatusResp {
  1: required TStatus status
  2: optional TOperationState operationState

  // If operationState is ERROR_STATE, then the following fields may be set
  // sqlState as defined in the ISO/IEF CLI specification
  3: optional string sqlState

  // Internal error code
  4: optional i32 errorCode

  // Error message
  5: optional string errorMessage

  // List of statuses of sub tasks
  6: optional string taskStatus

  // When was the operation started
  7: optional i64 operationStarted
  // When was the operation completed
  8: optional i64 operationCompleted

}


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 3253146 
  ql/src/java/org/apache/hadoop/hive/ql/TaskStatus.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java b184b4e 
  service-rpc/if/TCLIService.thrift 0aa9d13 
  service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828 
  service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java 8868ec1

  service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 35b6c52

  service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 8db2e62

  service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java d6f6280

  service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java a09b39a

  service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 740b851 
  service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2a0fec2

  service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java f5a9771

  service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff264 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165

  service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a 

Diff: https://reviews.apache.org/r/42134/diff/


Testing
-------


Thanks,

Akshay Goyal


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message