hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Amareshwari Sriramadasu <amareshw...@apache.org>
Subject Re: Review Request 44201: HIVE-13188: Allow users of RetryingThriftClient to close transport
Date Tue, 01 Mar 2016 08:25:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44201/#review121407
-----------------------------------------------------------




service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java (line
61)
<https://reviews.apache.org/r/44201/#comment183083>

    Can you update test to call new method introduced?


- Amareshwari Sriramadasu


On March 1, 2016, 7:18 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44201/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 7:18 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-13188
>     https://issues.apache.org/jira/browse/HIVE-13188
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> RetryingThriftCLIClient opens a TTransport and leaves it open. there should be a way
to close that.
> 
> 
> Diffs
> -----
> 
>   service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
a81c600236e6e0f53a484806e559303279244616 
>   service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java
3798053a4a2e2b26b97b5accf96d73b58c89fb6e 
> 
> Diff: https://reviews.apache.org/r/44201/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message