Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7B0E51825D for ; Fri, 19 Feb 2016 21:23:13 +0000 (UTC) Received: (qmail 56406 invoked by uid 500); 19 Feb 2016 21:23:13 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 56323 invoked by uid 500); 19 Feb 2016 21:23:13 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 56311 invoked by uid 99); 19 Feb 2016 21:23:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Feb 2016 21:23:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D2E612A64AD; Fri, 19 Feb 2016 21:23:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5974774809937262531==" MIME-Version: 1.0 Subject: Review Request 43785: HIVE-13099: Non-SQLOperations lead to Web UI NPE From: Mohit Sabharwal To: hive , Mohit Sabharwal Date: Fri, 19 Feb 2016 21:23:10 -0000 Message-ID: <20160219212310.13179.98151@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mohit Sabharwal X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43785/ X-Sender: Mohit Sabharwal Reply-To: Mohit Sabharwal X-ReviewRequest-Repository: hive-git --===============5974774809937262531== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43785/ ----------------------------------------------------------- Review request for hive. Bugs: HIVE-13099 https://issues.apache.org/jira/browse/HIVE-13099 Repository: hive-git Description ------- To support display of live operations in the WebUI, we record SQLOperations (in {{liveSqlOperations}}). However, to support historic operations, we save all operations in {{historicSqlOperations}}, including non-SQLOperations which do not have display entries in liveSqlOperations. This leads to a race condition depending on whether sessions use non-sql operations. Reproduce-able by issuing a 'set' operation. Diffs ----- service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 96c01de40fa581f1583fc3f9a93a2c71355ebc04 Diff: https://reviews.apache.org/r/43785/diff/ Testing ------- Thanks, Mohit Sabharwal --===============5974774809937262531==--