Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E7FCD18B75 for ; Wed, 17 Feb 2016 00:08:09 +0000 (UTC) Received: (qmail 41594 invoked by uid 500); 17 Feb 2016 00:08:09 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 41513 invoked by uid 500); 17 Feb 2016 00:08:09 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 41499 invoked by uid 99); 17 Feb 2016 00:08:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Feb 2016 00:08:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8D52D2A628D; Wed, 17 Feb 2016 00:08:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7236730483962535940==" MIME-Version: 1.0 Subject: Review Request 43553: HIVE-13057: Remove duplicate copies of TableDesc property values in PartitionDesc From: Mohit Sabharwal To: hive , Mohit Sabharwal Date: Wed, 17 Feb 2016 00:08:07 -0000 Message-ID: <20160217000807.13178.276@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mohit Sabharwal X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43553/ X-Sender: Mohit Sabharwal Reply-To: Mohit Sabharwal X-ReviewRequest-Repository: hive-git --===============7236730483962535940== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43553/ ----------------------------------------------------------- Review request for hive. Bugs: HIVE-13057 https://issues.apache.org/jira/browse/HIVE-13057 Repository: hive-git Description ------- For a partitioned table, each PartitionDesc has a copy of corresponding TableDesc. While TableDesc is mutable and hence cannot be interned, it's property values can be. For a simple select on a table with 100K partitions, this cut total number of String instances by ~65%. Most replicated strings were location, serde, input/output format, column, types, table name, etc. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/plan/PartitionDesc.java b032349b7faf7026928bea90a6ded29eeb2a502c Diff: https://reviews.apache.org/r/43553/diff/ Testing ------- Thanks, Mohit Sabharwal --===============7236730483962535940==--