hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rajat Khandelwal <>
Subject Re: Review Request 44146: HIVE-13179: Allow custom HiveConf to be passed to Authentication Providers
Date Mon, 29 Feb 2016 09:53:47 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 29, 2016, 3:23 p.m.)

Review request for hive.

Bugs: HIVE-13179

Repository: hive-git


Right now if I want to create an ldap auth provider, I have to create a hive-site.xml, set
endpoints and other relevant properties there, then instantiate `LdapAuthenticationProviderImpl`,
since inside the constructor, a new HiveConf is constructed. 

A better and more reusable design would be to ask for the conf in the constructor itself.
That will allow an external user to create a HiveConf, set all relevant properties and instantiate
`LdapAuthenticationProviderImpl` with that conf.

Diffs (updated)

  service/src/java/org/apache/hive/service/auth/ 4b95503

  service/src/java/org/apache/hive/service/auth/ 3dc0aa8

  service/src/java/org/apache/hive/service/auth/ 1d4aba2

  service/src/java/org/apache/hive/service/auth/ fd58081

  service/src/test/org/apache/hive/service/auth/ e5cee37

  service/src/test/org/apache/hive/service/auth/ 5e91a0e




Rajat Khandelwal

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message