hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Piotr Wikie? <piotr.wik...@allegrogroup.com>
Subject Re: Review Request 43651: HIVE-13075 | Metastore shuts down when no delegation token is found in ZooKeeper
Date Wed, 17 Feb 2016 17:55:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43651/
-----------------------------------------------------------

(Updated Lut 17, 2016, 5:55 po poĊ‚udniu)


Review request for hive.


Changes
-------

I've tested in only in hive 1 (branch-1 and branch-1.2)


Repository: hive-git


Description
-------

When you have multiple metastore instances storing tokens in ZooKeeper, there could be a race
condition in ExpiredTokenRemover causing one metastore to remove tokens already removed by
another instance. This is a simple solution for that problem. `null` is perfectly fine as
a return value in `ZooKeeperTokenStore::getToken`.


Diffs
-----

  shims/common/src/main/java/org/apache/hadoop/hive/thrift/ZooKeeperTokenStore.java 745e467


Diff: https://reviews.apache.org/r/43651/diff/


Testing
-------


Thanks,

Piotr Wikie?


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message