hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesús Camacho Rodríguez <jcamachorodrig...@hortonworks.com>
Subject Re: Review Request 43145: HIVE-12994
Date Mon, 08 Feb 2016 16:59:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43145/
-----------------------------------------------------------

(Updated Feb. 8, 2016, 4:59 p.m.)


Review request for hive and John Pullokkaran.


Bugs: HIVE-12994
    https://issues.apache.org/jira/browse/HIVE-12994


Repository: hive-git


Description
-------

Implement support for NULLS FIRST/NULLS LAST


Diffs (updated)
-----

  itests/src/test/resources/testconfiguration.properties b46b1605e585224b8c4bc177180b5dd68d14c97e

  metastore/if/hive_metastore.thrift 9d8c092ef8ab2d081e014fb84242451e69a37ad8 
  metastore/scripts/upgrade/derby/033-HIVE-12994.derby.sql PRE-CREATION 
  metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 660a85a4ab464bd69336d99b231edc47a6657850

  metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql 30de00bf034b5bc4470b4f515cd953586fd93658

  metastore/src/gen/protobuf/gen-java/org/apache/hadoop/hive/metastore/Metastore.java 416ae9d68d99110a2d9c2524e4156a43aac18ea6

  metastore/src/gen/protobuf/gen-java/org/apache/hadoop/hive/metastore/hbase/HbaseMetastoreProto.java
3b2d7b5db638dc6b35f968279d6b5129977e6f1d 
  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h c501ac0eb1ed8ced83a557e4843b2c52d7464602

  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 81577b612282f75e09a5a4a3b036fc03b0808ffb

  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Order.java cc0e2dd027d2e909ea4a39a742b33218c3f8411f

  metastore/src/gen/thrift/gen-php/metastore/Types.php 57d1dafcc75f734000f9c8fcd26f54bdcfc2a808

  metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 77dd9a6fcdaeea31b1d1bc58d3704630000a1d46

  metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 2cf433bff38ca69d8f13350c205e51fd51dab9a1

  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 6da295e246e2259647e32d8ba33c783b28d41550

  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java b8087287446ef243045a017768008829b5c4eb66

  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseUtils.java d6d01bdbb879397d1b28675f5dfaa345d9b1066f

  metastore/src/model/org/apache/hadoop/hive/metastore/model/MOrder.java 1fa82a4fde9d315d4955ee5698796f58ce8a0921

  metastore/src/protobuf/org/apache/hadoop/hive/metastore/hbase/hbase_metastore_proto.proto
466fdf9dc0b0e9d1c58c9b44977896780963e2ac 
  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java 29d5a64154fdb9ab9586fb919fbeae7106b1a874

  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java b0d76620b94b25c66b8e08571066660e6a8c8343

  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestSharedStorageDescriptor.java
e0d8ce4dede474ad1b752794379342993bf89fa4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java be6ea63fca44bf2bfbdc4368adc26c3d1448561d

  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 91b5ca769f88b04c379f38bad3518d36958f1c71

  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java e9cd450276511c36ecbdd0098c083871273f361d

  ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HybridHashTableContainer.java fdc1dfffd977ef3a71fcf56da19a3b2b91538921

  ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinBytesTableContainer.java 5c2ff9276b575f93a3df0fd2da378b85f7074a22

  ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinKey.java cfb9abc380880da2cefe6968fd81dc3b974ec1ed

  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java 1510fdd555223514786dfd9137103c1339c4fc2a

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java
7bdd11a1e46ac41f16fe26abebe8371fd1e41275 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 75d2519479fcdc00782049958207e11860ed78f4

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java b57dc77c23767f46c27fad0c5761bd2a79489f18

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java
d5f3057a5c070a22786d3151132dc59d38a0ebb4 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java c38c6d7f7b8503fed45ad9034b45064bbe3100dd

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java 27b04570b0fc2af41aaa41e83198e640ffc17e80

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 02db680c51f7767cd1369bff3b202eaa2367c481

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java 3f2267dc7926243b82d69cc65400b5b536081e53

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java
b42e78f796fb91b2bff3443972ad7512b18d68ee 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java
a0e374c744c880c6980a8abc7667d36c8ccba7e1 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java
638b91ec9f6a8cdc7af66d96955c40dca879776c 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkReduceSinkMapJoinProc.java f48fac138033b7cd128c34c3046644c4add838d3

  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java af1ee20a8636523a77b45bf596daddb1330b09d5

  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e2d404b0bd1d3916e498bc4c4076cdf168ef2272

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 4c4470be48931b66cc573b8bb0c295999241b182

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 5f14c6b6851125508b90b5b3886bc71c6c0c6ac3

  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 61bd10c9336a3e294675d055eab85ad9f7ff9122

  ql/src/java/org/apache/hadoop/hive/ql/parse/PTFInvocationSpec.java a8980ebd8e0cad32f0e087f15d19cd6d015490da

  ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java 2370ec06cebdb49da4ef3d56d11d7fef8025be6b

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ba1945f542b68069584182d10433d0a33a847027

  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 598520c133f56ac515a90c4800dce13b16a0d71e

  ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 04d26f310718b7e8066ed1d7e5b3537f04d5101c

  ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 41d9ffe5ca13863e35d106f41e35a46af0d0ecf1

  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/OrderExpressionDef.java e367d138335a4484b0704b5333648896a86d7551

  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PartitionedTableFunctionDef.java 2a8b1c01da7b99f033c3b53db7c5942777b8ef7d

  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java 2c076f509d5597c48c491f72831fb2c5ae3e1c2e

  ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestWorker.java cf7eb703a158dd5d1236641eb1f9f004a04d5e7b

  ql/src/test/queries/clientpositive/order_null.q PRE-CREATION 
  ql/src/test/results/clientpositive/alter_numbuckets_partitioned_table2_h23.q.out 3b71598e6f5c0623edc19c82d31c6fbe67c1e5c0

  ql/src/test/results/clientpositive/alter_numbuckets_partitioned_table_h23.q.out cab3de4d0229d82134e9ce44899f1b2703790baa

  ql/src/test/results/clientpositive/alter_partition_clusterby_sortby.q.out 184d2e42d5b1acedf3ea45015811b12f82fe9ec5

  ql/src/test/results/clientpositive/alter_table_not_sorted.q.out 6e1ec59b143897a50603f3d039829915fa57ad20

  ql/src/test/results/clientpositive/authorization_index.q.out adc02ad5c19a3a153546db5d61b6351fcb00cbb1

  ql/src/test/results/clientpositive/bucket5.q.out 46e3d54c4b8898eeb864b2c2f6d223263450f883

  ql/src/test/results/clientpositive/bucketmapjoin7.q.out afa7c9014323065b3b9274803868eda629277d14

  ql/src/test/results/clientpositive/correlationoptimizer12.q.out 1237b2646654848f896f0cb21fd6bf17eb34e8c8

  ql/src/test/results/clientpositive/ctas.q.out bf6db75852ba03a34da4dd022049b63577620821 
  ql/src/test/results/clientpositive/ctas_colname.q.out 435b9e0a057481b7518d5ef13ad2b0dbc12c2def

  ql/src/test/results/clientpositive/dynpart_sort_opt_vectorization.q.out bc5a580d47373600725aad84e5c3390b4f25b86d

  ql/src/test/results/clientpositive/dynpart_sort_optimization.q.out 2105d8b722ca753faa6e550aaf1c08f3a2475619

  ql/src/test/results/clientpositive/explain_logical.q.out 8124b7a40644693175e3146a70d3d9bb37517637

  ql/src/test/results/clientpositive/groupby_grouping_window.q.out d9251680b15f7615a0e02aa5770bce8c36af8c58

  ql/src/test/results/clientpositive/groupby_resolution.q.out 0bc365c22ba9688da0a5154a3c782a5e9a3f9f9c

  ql/src/test/results/clientpositive/index_skewtable.q.out 10a441d87f44f1a68ab62f6c433d0ecafad88cb1

  ql/src/test/results/clientpositive/infer_bucket_sort.q.out 182dd3ad8ac09d04ab19c5030ed0eaffeda5fbfd

  ql/src/test/results/clientpositive/infer_bucket_sort_bucketed_table.q.out 33d795b795569b1435ebc0812f06c6d9f656f931

  ql/src/test/results/clientpositive/infer_bucket_sort_convert_join.q.out 2f7e53813dc364a073d78a31d397d02b00e8bc85

  ql/src/test/results/clientpositive/infer_bucket_sort_dyn_part.q.out 7e3b48f75e16962216d887899299da91e8a0ea07

  ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out ebfce60c5920c6565fc1a6e2108016a548a52f12

  ql/src/test/results/clientpositive/infer_bucket_sort_map_operators.q.out 4ca65173cc84f83af8956e515a81c3c5b5c29d09

  ql/src/test/results/clientpositive/infer_bucket_sort_merge.q.out 53407c5b97214d23b7b1e1bb753face87d983ffa

  ql/src/test/results/clientpositive/infer_bucket_sort_multi_insert.q.out d4c22f4da6d9b332382be5f75919140c49af4297

  ql/src/test/results/clientpositive/infer_bucket_sort_reducers_power_two.q.out 1e4db29110bb32555d76c613f8216ef9bbfa62b9

  ql/src/test/results/clientpositive/input_part7.q.out 42198f3a3e1fad2818396e3ad29a45eb10218ffb

  ql/src/test/results/clientpositive/lineage2.q.out ec64c10d0c598ca813d10e52f01526a3f81da63c

  ql/src/test/results/clientpositive/lineage3.q.out ca7d6e08a361cdaea3179afa3b946ce173893a26

  ql/src/test/results/clientpositive/orc_analyze.q.out 87855fa9861ba443eea404f320fb306e09e7cfc0

  ql/src/test/results/clientpositive/order_null.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/partition_coltype_literals.q.out bc159eb064cafc8bda630ee97a3a6fee49beee9a

  ql/src/test/results/clientpositive/pcr.q.out 010acfded3cf24adc762074b932b9d1f5b81cd65 
  ql/src/test/results/clientpositive/pcs.q.out de385ffca9a9251ceb4eb2011c9b122ce96aaf52 
  ql/src/test/results/clientpositive/perf/query12.q.out f326a926e8a14e3d94788b457ab1ced66321289d

  ql/src/test/results/clientpositive/perf/query20.q.out 74d286a68ef49f18ecc0c11cead3e89bc63560ab

  ql/src/test/results/clientpositive/perf/query51.q.out f568ead3120e157bce37837a241e225c0f83cd6f

  ql/src/test/results/clientpositive/perf/query67.q.out f158829f7446c0698a258f4b0bfcc928ad92d6c6

  ql/src/test/results/clientpositive/perf/query70.q.out 9b58fdb238ac8c718df5a357fd82b8fdf1d075e3

  ql/src/test/results/clientpositive/perf/query89.q.out 4d0fb37daf6a6460307fd1b74b8794a2cb258b78

  ql/src/test/results/clientpositive/perf/query98.q.out f51744dacf0dbc70e26ecdd15f3d0b18687c671f

  ql/src/test/results/clientpositive/pointlookup2.q.out 1cfa4b6345ab48f6cac437a2dbefc657016a4b6d

  ql/src/test/results/clientpositive/pointlookup3.q.out aa0ac54a3201d11941bf03cec9ce52e40973e00f

  ql/src/test/results/clientpositive/pointlookup4.q.out 3a8b7a67e14defe5c546950a6f585831fccb9afd

  ql/src/test/results/clientpositive/ppd_vc.q.out 5165826243f6880c6eccc4492b9e730723f90eda

  ql/src/test/results/clientpositive/ptf.q.out 56506f7a439ee76c79a2f019c2b6a8e2eb5e3d9a 
  ql/src/test/results/clientpositive/ptf_matchpath.q.out dd4b65fcd6c7ab1c9a1ff7f0b0bcaa6459d2c776

  ql/src/test/results/clientpositive/ptf_streaming.q.out 43b2f7af580fe967cba732b012b2ecdc1a6bf3a9

  ql/src/test/results/clientpositive/ptfgroupbyjoin.q.out b726320b69ed88e9f2fa7f8bb8d166cf95329821

  ql/src/test/results/clientpositive/push_or.q.out 643e4abd3f1f788794fb759a206f1d7d6fb4b6e7

  ql/src/test/results/clientpositive/quotedid_basic.q.out 485aa9050f880d84d0a758f5e40350dc5496da80

  ql/src/test/results/clientpositive/sample10.q.out d8d9c8894ffe41e9a082ef56da5d7a01d2413312

  ql/src/test/results/clientpositive/sample6.q.out e0ccc97c0c467420366eea46fb8fb888feb8dd01

  ql/src/test/results/clientpositive/semijoin2.q.out e7d7271f9b99b689dfbf6105aa543a9bd6032d35

  ql/src/test/results/clientpositive/semijoin4.q.out 77f2615b981215532d6f6092f339ce7bd5bea2a7

  ql/src/test/results/clientpositive/show_create_table_alter.q.out 32819ea34ee15dc23dfaca0ec4fde504a397b7de

  ql/src/test/results/clientpositive/smb_mapjoin_13.q.out 1625162a8da2d1a43124674e59d1ea1cae1c17e4

  ql/src/test/results/clientpositive/smb_mapjoin_15.q.out ec00668a6ca8f8002c47da317f0d9340f75e4462

  ql/src/test/results/clientpositive/spark/bucket5.q.out 547b0cdad7a9c3b3e0bfed0b847c372f1da67430

  ql/src/test/results/clientpositive/spark/bucketmapjoin7.q.out 30a03e50ca76eb92c02420a31db71b3dee53c113

  ql/src/test/results/clientpositive/spark/ctas.q.out 175344cc28c131080ec0a6bd0247a8e84e765dfa

  ql/src/test/results/clientpositive/spark/groupby_resolution.q.out 72f48ee27addb9082fa43536eaab9ace9557b2f6

  ql/src/test/results/clientpositive/spark/infer_bucket_sort_bucketed_table.q.out 33d795b795569b1435ebc0812f06c6d9f656f931

  ql/src/test/results/clientpositive/spark/pcr.q.out 3e438d6c1579086a41a455316797c4b0e8150e27

  ql/src/test/results/clientpositive/spark/ptf.q.out 98bfa7795d296f6d1684c5d94e28321cc66fdf3e

  ql/src/test/results/clientpositive/spark/ptf_matchpath.q.out f9a9734e3da4f7da57185201cfab98313c1a5aba

  ql/src/test/results/clientpositive/spark/ptf_streaming.q.out 88e8f76ea4981a442e5e9841f6c0909d05d73b11

  ql/src/test/results/clientpositive/spark/sample10.q.out 502a509abcbd52869820ba13333d58ef6a856e13

  ql/src/test/results/clientpositive/spark/sample6.q.out 8f6c164d59115f8ab55267bfe7b56886455da8b0

  ql/src/test/results/clientpositive/spark/smb_mapjoin_13.q.out 950e768cdf1bfbede8e1b18a585d371ebc19648d

  ql/src/test/results/clientpositive/spark/smb_mapjoin_15.q.out 1c32b8f644e2f2e1d306410bdb6805c054b180cc

  ql/src/test/results/clientpositive/spark/subquery_in.q.out dc9109c1afa3e1bfec8f546bc3aa84bd5b854de6

  ql/src/test/results/clientpositive/spark/union_ppr.q.out d5ba4bc000fe4d6c3925b83fef110f2bed4f8757

  ql/src/test/results/clientpositive/spark/union_remove_6_subq.q.out 372971c6410a0369d6620b2dfd60b14d27c39b28

  ql/src/test/results/clientpositive/spark/vectorized_ptf.q.out 3e2a189a69d56e8cb224b6ddf3034750852ee694

  ql/src/test/results/clientpositive/subquery_in.q.out 0bbefc2c1db11667599f27d8234853a2b47db970

  ql/src/test/results/clientpositive/subquery_in_having.q.out 87c5a623dfa44e903710794634e459dc66bbd86a

  ql/src/test/results/clientpositive/subquery_notin.q.out e157ff4d511cd7a4729f3c1d39800e80788ee48a

  ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 4cc5424086cd22c7465a839fffd2171a320c7c98

  ql/src/test/results/clientpositive/tez/ctas.q.out 74e8b98bacb3121fe227f29e04c0b855deaaa30a

  ql/src/test/results/clientpositive/tez/dynpart_sort_opt_vectorization.q.out d48e2fb54622932d677f52998c010d04e6fd5cb5

  ql/src/test/results/clientpositive/tez/dynpart_sort_optimization.q.out a28f0a4429bb86ace8d47ebf2e3b21895de0b52f

  ql/src/test/results/clientpositive/tez/explainuser_1.q.out 120894da3304d06eb9e227bb865e86b696359eb9

  ql/src/test/results/clientpositive/tez/orc_analyze.q.out 87855fa9861ba443eea404f320fb306e09e7cfc0

  ql/src/test/results/clientpositive/tez/order_null.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/tez/ptf.q.out d49d02897d962a2765b7a7d2b8bef968a5ed6e2d

  ql/src/test/results/clientpositive/tez/ptf_matchpath.q.out 152166b09ca5718c1636a82d84b84d614d4afa4d

  ql/src/test/results/clientpositive/tez/ptf_streaming.q.out 61bcfc92dd5cd16702821aab5ee43b3198f172c7

  ql/src/test/results/clientpositive/tez/subquery_in.q.out 2c04009d19a1deafcfcd9252ace454f2194e821e

  ql/src/test/results/clientpositive/tez/vectorized_ptf.q.out d109e2543c61305eae0f375f15b1221265729505

  ql/src/test/results/clientpositive/tez/windowing_gby.q.out 2af3e580f09e82e20de479c44affe8a5dddb7aaa

  ql/src/test/results/clientpositive/union_ppr.q.out 9a2d7fb4d3274b8c1cf8a85a4daf636461b90e3d

  ql/src/test/results/clientpositive/union_remove_6_subq.q.out 05363e44b6674cb5e6c306996688f2fe4c445908

  ql/src/test/results/clientpositive/vectorized_ptf.q.out ce7f8046ce623cdde4d4e37c1766b72587003d82

  ql/src/test/results/clientpositive/windowing_streaming.q.out f4afbe0ba82fb254c2002d8d12848268e5f74bb5

  serde/if/serde.thrift 40d5f47391bcb6408ba53f727d3020aadcc29c5c 
  serde/src/gen/thrift/gen-cpp/serde_constants.h 3566ead87ebcf7b76bfb71f0bd9874d7acd5603b

  serde/src/gen/thrift/gen-cpp/serde_constants.cpp 243d3b8f11a999142c1801bfa7d3c5deab846628

  serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java 8b3eeb763bdab677a520535884abb2893ee85643

  serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 8370698933b2c2466aa7d5cdf499f640c5920996

  serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 6ef3bcfd6e7faa448c31722b9ba78d68eb331a6d

  serde/src/gen/thrift/gen-rb/serde_constants.rb f98441b48b113ddd801755b72b87ed39ad1f4ab2

  serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 144ea5a025e5b0c118ab35230ee4059d08efe38f

  serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDeWithEndPrefix.java
ec43ae3e6480deaa0cc15e96da76dd8e776f3268 
  serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/fast/BinarySortableSerializeWrite.java
9ea6e914c58effda11a5db93077ed99ab1d75e1f 
  serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableFast.java
ae476aeeb143b83f1773e40eff0d629150560b76 
  serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableSerDe.java
af47e6f7082e464079a62df898d38ceecd9bfb61 

Diff: https://reviews.apache.org/r/43145/diff/


Testing
-------

Current testsuite to verify that default behavior has not changed.
Added q file with different cases.
We still need to add additional test cases.


Thanks,

Jesús Camacho Rodríguez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message