hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesús Camacho Rodríguez <jcamachorodrig...@hortonworks.com>
Subject Re: Review Request 43145: HIVE-12994
Date Fri, 05 Feb 2016 17:52:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43145/
-----------------------------------------------------------

(Updated Feb. 5, 2016, 5:52 p.m.)


Review request for hive and John Pullokkaran.


Changes
-------

Fixes related to windowing.


Bugs: HIVE-12994
    https://issues.apache.org/jira/browse/HIVE-12994


Repository: hive-git


Description
-------

Implement support for NULLS FIRST/NULLS LAST


Diffs (updated)
-----

  itests/src/test/resources/testconfiguration.properties fd2c924380320007245ffd55af5b7809ce4b5201

  metastore/if/hive_metastore.thrift 9d8c092ef8ab2d081e014fb84242451e69a37ad8 
  metastore/scripts/upgrade/derby/033-HIVE-12994.derby.sql PRE-CREATION 
  metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 660a85a4ab464bd69336d99b231edc47a6657850

  metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql 30de00bf034b5bc4470b4f515cd953586fd93658

  metastore/src/gen/protobuf/gen-java/org/apache/hadoop/hive/metastore/Metastore.java 416ae9d68d99110a2d9c2524e4156a43aac18ea6

  metastore/src/gen/protobuf/gen-java/org/apache/hadoop/hive/metastore/hbase/HbaseMetastoreProto.java
3b2d7b5db638dc6b35f968279d6b5129977e6f1d 
  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h c501ac0eb1ed8ced83a557e4843b2c52d7464602

  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 81577b612282f75e09a5a4a3b036fc03b0808ffb

  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Order.java cc0e2dd027d2e909ea4a39a742b33218c3f8411f

  metastore/src/gen/thrift/gen-php/metastore/Types.php 57d1dafcc75f734000f9c8fcd26f54bdcfc2a808

  metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 77dd9a6fcdaeea31b1d1bc58d3704630000a1d46

  metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 2cf433bff38ca69d8f13350c205e51fd51dab9a1

  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java be54b9ca6e7991e08b95892c8f2a2f460f824434

  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java b8087287446ef243045a017768008829b5c4eb66

  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseUtils.java d6d01bdbb879397d1b28675f5dfaa345d9b1066f

  metastore/src/model/org/apache/hadoop/hive/metastore/model/MOrder.java 1fa82a4fde9d315d4955ee5698796f58ce8a0921

  metastore/src/protobuf/org/apache/hadoop/hive/metastore/hbase/hbase_metastore_proto.proto
466fdf9dc0b0e9d1c58c9b44977896780963e2ac 
  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java 29d5a64154fdb9ab9586fb919fbeae7106b1a874

  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java b0d76620b94b25c66b8e08571066660e6a8c8343

  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestSharedStorageDescriptor.java
e0d8ce4dede474ad1b752794379342993bf89fa4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java be6ea63fca44bf2bfbdc4368adc26c3d1448561d

  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 91b5ca769f88b04c379f38bad3518d36958f1c71

  ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java e9cd450276511c36ecbdd0098c083871273f361d

  ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HybridHashTableContainer.java fdc1dfffd977ef3a71fcf56da19a3b2b91538921

  ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinBytesTableContainer.java 5c2ff9276b575f93a3df0fd2da378b85f7074a22

  ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinKey.java cfb9abc380880da2cefe6968fd81dc3b974ec1ed

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java
7bdd11a1e46ac41f16fe26abebe8371fd1e41275 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 75d2519479fcdc00782049958207e11860ed78f4

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java b57dc77c23767f46c27fad0c5761bd2a79489f18

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java
d5f3057a5c070a22786d3151132dc59d38a0ebb4 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java c38c6d7f7b8503fed45ad9034b45064bbe3100dd

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java 27b04570b0fc2af41aaa41e83198e640ffc17e80

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 02db680c51f7767cd1369bff3b202eaa2367c481

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java 3f2267dc7926243b82d69cc65400b5b536081e53

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java
b42e78f796fb91b2bff3443972ad7512b18d68ee 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java
a0e374c744c880c6980a8abc7667d36c8ccba7e1 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java
638b91ec9f6a8cdc7af66d96955c40dca879776c 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkReduceSinkMapJoinProc.java f48fac138033b7cd128c34c3046644c4add838d3

  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java af1ee20a8636523a77b45bf596daddb1330b09d5

  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e2d404b0bd1d3916e498bc4c4076cdf168ef2272

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 4c4470be48931b66cc573b8bb0c295999241b182

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 5f14c6b6851125508b90b5b3886bc71c6c0c6ac3

  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 61bd10c9336a3e294675d055eab85ad9f7ff9122

  ql/src/java/org/apache/hadoop/hive/ql/parse/PTFInvocationSpec.java a8980ebd8e0cad32f0e087f15d19cd6d015490da

  ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java 2370ec06cebdb49da4ef3d56d11d7fef8025be6b

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ba1945f542b68069584182d10433d0a33a847027

  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 598520c133f56ac515a90c4800dce13b16a0d71e

  ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 04d26f310718b7e8066ed1d7e5b3537f04d5101c

  ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 41d9ffe5ca13863e35d106f41e35a46af0d0ecf1

  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/OrderExpressionDef.java e367d138335a4484b0704b5333648896a86d7551

  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PartitionedTableFunctionDef.java 2a8b1c01da7b99f033c3b53db7c5942777b8ef7d

  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java 2c076f509d5597c48c491f72831fb2c5ae3e1c2e

  ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestWorker.java cf7eb703a158dd5d1236641eb1f9f004a04d5e7b

  ql/src/test/queries/clientpositive/order_null.q PRE-CREATION 
  ql/src/test/results/clientpositive/order_null.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/tez/order_null.q.out PRE-CREATION 
  serde/if/serde.thrift 40d5f47391bcb6408ba53f727d3020aadcc29c5c 
  serde/src/gen/thrift/gen-cpp/serde_constants.h 3566ead87ebcf7b76bfb71f0bd9874d7acd5603b

  serde/src/gen/thrift/gen-cpp/serde_constants.cpp 243d3b8f11a999142c1801bfa7d3c5deab846628

  serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java 8b3eeb763bdab677a520535884abb2893ee85643

  serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php 8370698933b2c2466aa7d5cdf499f640c5920996

  serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py 6ef3bcfd6e7faa448c31722b9ba78d68eb331a6d

  serde/src/gen/thrift/gen-rb/serde_constants.rb f98441b48b113ddd801755b72b87ed39ad1f4ab2

  serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 144ea5a025e5b0c118ab35230ee4059d08efe38f

  serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDeWithEndPrefix.java
ec43ae3e6480deaa0cc15e96da76dd8e776f3268 
  serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/fast/BinarySortableSerializeWrite.java
9ea6e914c58effda11a5db93077ed99ab1d75e1f 
  serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableFast.java
ae476aeeb143b83f1773e40eff0d629150560b76 
  serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableSerDe.java
af47e6f7082e464079a62df898d38ceecd9bfb61 

Diff: https://reviews.apache.org/r/43145/diff/


Testing
-------

Current testsuite to verify that default behavior has not changed.
Added q file with different cases.
We still need to add additional test cases.


Thanks,

Jesús Camacho Rodríguez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message