hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aihua Xu <...@cloudera.com>
Subject Review Request 43192: HIVE-9534: incorrect result set for query that projects a windowed aggregate
Date Thu, 04 Feb 2016 16:27:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43192/
-----------------------------------------------------------

Review request for hive, Chaoyu Tang, Szehon Ho, Xuefu Zhang, and Yongzhi Chen.


Repository: hive-git


Description
-------

HIVE-9534: incorrect result set for query that projects a windowed aggregate


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/CanAggregateDistinct.java
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/HiveSqlCountAggFunction.java
58191e5e6e3d999f176884c6b71e6a781d9ba3ff 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/HiveSqlSumAggFunction.java
498cd0ecaa52afa890e22a4f35754ad15dd4664d 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java
19aa414419bc0d3525ce3d05a59e2a17724b495e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java cd2449fdc2d1cdd595c764e9b3da4c0811b2e763

  ql/src/test/queries/clientpositive/windowing_distinct.q 9f6ddfd0934bc695f69576b5a7523fe7d49be4e6

  ql/src/test/results/clientpositive/windowing_distinct.q.out 0858f0f38c977c77fd0fc9919094f48ebf3a09f3


Diff: https://reviews.apache.org/r/43192/diff/


Testing
-------

Similar to sum(distinct) and count(distinct) supported, add avg(distinct) in this patch.


Thanks,

Aihua Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message