Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E5CC18A01 for ; Fri, 29 Jan 2016 12:15:41 +0000 (UTC) Received: (qmail 19964 invoked by uid 500); 29 Jan 2016 12:15:41 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 19886 invoked by uid 500); 29 Jan 2016 12:15:41 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 19870 invoked by uid 99); 29 Jan 2016 12:15:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jan 2016 12:15:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0E530289960; Fri, 29 Jan 2016 12:15:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7449027194874693204==" MIME-Version: 1.0 Subject: Re: Review Request 41928: HIVE-12777: Add capability to restore session From: Amareshwari Sriramadasu To: Amareshwari Sriramadasu , hive Date: Fri, 29 Jan 2016 12:15:40 -0000 Message-ID: <20160129121540.12172.6088@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Amareshwari Sriramadasu X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41928/ In-Reply-To: <20160129072408.25059.96053@reviews.apache.org> X-Sender: Amareshwari Sriramadasu X-ReviewBoard-ShipIt: 1 References: <20160129072408.25059.96053@reviews.apache.org> X-ReviewBoard-Diff-For: service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java X-ReviewBoard-ShipIt-Only: 1 Reply-To: Amareshwari Sriramadasu X-ReviewRequest-Repository: hive-git --===============7449027194874693204== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/#review116943 ----------------------------------------------------------- Ship it! Ship It! - Amareshwari Sriramadasu On Jan. 29, 2016, 7:24 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41928/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2016, 7:24 a.m.) > > > Review request for hive. > > > Bugs: HIVE-12777 > https://issues.apache.org/jira/browse/HIVE-12777 > > > Repository: hive-git > > > Description > ------- > > Extensions using Hive session handles should be able to restore the hive session from the handle. > > Apache Lens depends on a fork of hive and that fork has such a capability. > > Relevant commit: https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be > > > Diffs > ----- > > service/src/java/org/apache/hive/service/cli/CLIService.java 0d5ae1e491bdcf98a12f5eef7b35f23c7b9dfc00 > service/src/java/org/apache/hive/service/cli/SessionHandle.java 4e4f0211de09408168c8da669626fb49f3db364c > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 3c5700bd114f6b792df10df23e57dad9b9e689f6 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java c56d97afc969ea57810e9b3222b20e086e847d67 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java de18f1d93502704e7a8fbb8d31d93bd770c4d232 > service/src/test/org/apache/hive/service/cli/CLIServiceRestoreTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/41928/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > > --===============7449027194874693204==--