Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C4E818F7A for ; Wed, 20 Jan 2016 22:18:30 +0000 (UTC) Received: (qmail 31178 invoked by uid 500); 20 Jan 2016 22:18:30 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 31082 invoked by uid 500); 20 Jan 2016 22:18:30 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 31054 invoked by uid 99); 20 Jan 2016 22:18:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jan 2016 22:18:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 62AD7282361; Wed, 20 Jan 2016 22:18:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7751770064817727817==" MIME-Version: 1.0 Subject: Re: Review Request 42359: HIVE-12805: CBO: Calcite Operator To Hive Operator (Calcite Return Path): MiniTezCliDriver skewjoin.q failure From: "Ashutosh Chauhan" To: John Pullokkaran , =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= , Ashutosh Chauhan Cc: "hive" , "Hari Sankar Sivarama Subramaniyan" Date: Wed, 20 Jan 2016 22:18:28 -0000 Message-ID: <20160120221828.32039.71974@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ashutosh Chauhan" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42359/ X-Sender: "Ashutosh Chauhan" References: <20160119210055.7986.43953@reviews.apache.org> In-Reply-To: <20160119210055.7986.43953@reviews.apache.org> Reply-To: "Ashutosh Chauhan" X-ReviewRequest-Repository: hive-git --===============7751770064817727817== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42359/#review115499 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java (line 263) Do we really need to find uniqueness of expression? Can we do numKeys = joinLeafPredInfo.getJoinExprs(i).size() ? - Ashutosh Chauhan On Jan. 19, 2016, 9 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42359/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2016, 9 p.m.) > > > Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > HIVE-12805 CBO: Calcite Operator To Hive Operator (Calcite Return Path): MiniTezCliDriver skewjoin.q failure > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java 660f01d > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveInsertExchange4JoinRule.java d6e3915 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java 5d169a1 > > Diff: https://reviews.apache.org/r/42359/diff/ > > > Testing > ------- > > Clean precommit > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > > --===============7751770064817727817==--