Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 59BEE18E87 for ; Mon, 18 Jan 2016 10:36:08 +0000 (UTC) Received: (qmail 12782 invoked by uid 500); 18 Jan 2016 10:36:07 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 12691 invoked by uid 500); 18 Jan 2016 10:36:07 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 12677 invoked by uid 99); 18 Jan 2016 10:36:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2016 10:36:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B33A42814F8; Mon, 18 Jan 2016 10:36:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7238487327167314851==" MIME-Version: 1.0 Subject: Re: Review Request 42392: HIVE-12049: WIP Patch: Add a serde to serialize JDBC ResultSet in Tasks From: "Vaibhav Gumashta" To: "Rohit Dholakia" , "Thejas Nair" Cc: "Vaibhav Gumashta" , "hive" Date: Mon, 18 Jan 2016 10:36:06 -0000 Message-ID: <20160118103606.32038.64079@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Vaibhav Gumashta" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42392/ X-Sender: "Vaibhav Gumashta" References: <20160118050324.32039.46244@reviews.apache.org> In-Reply-To: <20160118050324.32039.46244@reviews.apache.org> Reply-To: "Vaibhav Gumashta" X-ReviewRequest-Repository: hive-git --===============7238487327167314851== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42392/ ----------------------------------------------------------- (Updated Jan. 18, 2016, 10:36 a.m.) Review request for hive, Rohit Dholakia and Thejas Nair. Bugs: HIVE-12049 https://issues.apache.org/jira/browse/HIVE-12049 Repository: hive-git Description ------- https://issues.apache.org/jira/browse/HIVE-12049 Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2c25cae jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java 98d0370 jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java 16a0894 jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java 691fd0e ql/src/java/org/apache/hadoop/hive/ql/exec/DefaultFetchFormatter.java b8be3a5 ql/src/java/org/apache/hadoop/hive/ql/exec/FetchFormatter.java c2ed0d6 ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 32bfcf5 ql/src/java/org/apache/hadoop/hive/ql/exec/ListSinkOperator.java 919e72f ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c38699d ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java a8f9f50 ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 5bea6fb serde/pom.xml e025a4e serde/src/java/org/apache/hadoop/hive/serde2/DefaultFetchFormatter.java PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/FetchFormatter.java PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 90439a2 serde/src/java/org/apache/hadoop/hive/serde2/thrift/ColumnBuffer.java PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/thrift/ThriftFormatter.java PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/thrift/ThriftJDBCBinarySerDe.java PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/thrift/Type.java PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java 70dc181 service/src/java/org/apache/hive/service/cli/Column.java 102d920 service/src/java/org/apache/hive/service/cli/ColumnBasedSet.java b7fe663 service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java 7bd9f06 service/src/java/org/apache/hive/service/cli/ColumnValue.java 37460e6 service/src/java/org/apache/hive/service/cli/TableSchema.java 2206e2c service/src/java/org/apache/hive/service/cli/Type.java f067b3d service/src/java/org/apache/hive/service/cli/TypeDescriptor.java b4a5b77 service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 35b6c52 service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 8db2e62 service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2a0fec2 service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 3c5700b service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a service/src/test/org/apache/hive/service/cli/TestColumn.java 87bf848 Diff: https://reviews.apache.org/r/42392/diff/ Testing ------- WIP Patch while I cleanup my local commits to generate complete patch(es). But will be useful to get review started. Limited testing done as of now. Thanks, Vaibhav Gumashta --===============7238487327167314851==--