Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9344918B71 for ; Mon, 11 Jan 2016 23:05:26 +0000 (UTC) Received: (qmail 24193 invoked by uid 500); 11 Jan 2016 23:05:26 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 24088 invoked by uid 500); 11 Jan 2016 23:05:25 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 24068 invoked by uid 99); 11 Jan 2016 23:05:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 23:05:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 265B0280653; Mon, 11 Jan 2016 23:05:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8077014074478043916==" MIME-Version: 1.0 Subject: Re: Review Request 42081: HIVE-12788: Setting hive.optimize.union.remove to TRUE will break UNION ALL with aggregate functions From: "pengcheng xiong" To: "pengcheng xiong" , "Xuefu Zhang" , "Ashutosh Chauhan" Cc: "hive" , "Chaoyu Tang" Date: Mon, 11 Jan 2016 23:05:25 -0000 Message-ID: <20160111230525.26386.59084@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "pengcheng xiong" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42081/ X-Sender: "pengcheng xiong" References: <20160110141721.26792.37871@reviews.apache.org> In-Reply-To: <20160110141721.26792.37871@reviews.apache.org> Reply-To: "pengcheng xiong" X-ReviewRequest-Repository: hive-git --===============8077014074478043916== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42081/#review113865 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java (line 226) The patch looks good to me. +1. Could you put the reason that we discussed before here so that people will have a better understanding? And also please list the future work to improve it. Thanks. - pengcheng xiong On Jan. 10, 2016, 2:17 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42081/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2016, 2:17 p.m.) > > > Review request for hive, Ashutosh Chauhan, pengcheng xiong, and Xuefu Zhang. > > > Bugs: HIVE-12788 > https://issues.apache.org/jira/browse/HIVE-12788 > > > Repository: hive-git > > > Description > ------- > > adds StatsOptimizator support to union with aggregate function. Otherwise, it always returns one row. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 03c1c3f > ql/src/test/queries/clientpositive/union_remove_26.q PRE-CREATION > ql/src/test/results/clientpositive/union_remove_26.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/42081/diff/ > > > Testing > ------- > > 1. Manual tests for some partitcular cases > 2. submitted to precommit-tests > > > Thanks, > > Chaoyu Tang > > --===============8077014074478043916==--