Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1FEF018A9D for ; Mon, 11 Jan 2016 11:43:18 +0000 (UTC) Received: (qmail 52724 invoked by uid 500); 11 Jan 2016 11:43:17 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 52641 invoked by uid 500); 11 Jan 2016 11:43:17 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 52626 invoked by uid 99); 11 Jan 2016 11:43:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 11:43:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DBC761D2740; Mon, 11 Jan 2016 11:43:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3701805385522064245==" MIME-Version: 1.0 Subject: Re: Review Request 41928: HIVE-12777: Add capability to restore session From: "Amareshwari Sriramadasu" To: "Amareshwari Sriramadasu" , "hive" Date: Mon, 11 Jan 2016 11:43:16 -0000 Message-ID: <20160111114316.26792.98264@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Amareshwari Sriramadasu" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41928/ X-Sender: "Amareshwari Sriramadasu" References: <20160111102233.26792.54556@reviews.apache.org> In-Reply-To: <20160111102233.26792.54556@reviews.apache.org> Reply-To: "Amareshwari Sriramadasu" X-ReviewRequest-Repository: hive-git --===============3701805385522064245== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/#review113730 ----------------------------------------------------------- service/src/test/org/apache/hive/service/cli/CLIServiceTest.java (line 94) Can you do some operations on restored session? - Amareshwari Sriramadasu On Jan. 11, 2016, 10:22 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41928/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 10:22 a.m.) > > > Review request for hive. > > > Bugs: HIVE-12777 > https://issues.apache.org/jira/browse/HIVE-12777 > > > Repository: hive-git > > > Description > ------- > > Extensions using Hive session handles should be able to restore the hive session from the handle. > > Apache Lens depends on a fork of hive and that fork has such a capability. > > Relevant commit: https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85 > service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 > service/src/gen/thrift/gen-cpp/TCLIService.h 2ea80c76e4e8618c5535f8270f20c70c8b35f765 > service/src/gen/thrift/gen-cpp/TCLIService.cpp 7e2c028dc5e038e40d4dfb5e06a80789b4eabe3b > service/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 988bb4c11ddb717f585e0ba2fb4773ec5fff77e6 > service/src/gen/thrift/gen-cpp/TCLIService_types.h b078c99db2f436e1ac32514b8f873c150952900b > service/src/gen/thrift/gen-cpp/TCLIService_types.cpp b85237994f8019bd58aa1c8fdbef3aabce9940e2 > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIService.java ded848f2b81bf698a819732a2e9ea4bc67fd2a26 > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java 30cf243f541304a2ac05c775c912d542520ebe05 > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java 4f2273214ab43b1116008183ff42a520769c6710 > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionReq.java PRE-CREATION > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRestoreSessionResp.java PRE-CREATION > service/src/gen/thrift/gen-php/TCLIService.php eba62f12de0899280b9961dd82330bb149d40758 > service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 56f5c5dc36d44627a2cd571c2bc1fcd1a79e62f2 > service/src/gen/thrift/gen-py/TCLIService/TCLIService.py ad2d71d720376c76632d9e3a147f227b3ff67c17 > service/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f568ffec92c093bdd0904c154f8ee67606e > service/src/gen/thrift/gen-rb/t_c_l_i_service.rb 7d7f7a78a17cab50b18fa77805022bf4ca0197d9 > service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec40afd29ab4ed452f65f306cb1af5ff5207 > service/src/java/org/apache/hive/service/cli/CLIService.java adc98098437b2d0429dd2af40d8eaae323fbf3f0 > service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 3155c238ff688bfea16b0aaeea950599bb659b5b > service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be198c063115a8e90c67b1c2fd910ca8bc6 > service/src/java/org/apache/hive/service/cli/ICLIService.java c9cc1f4da56f1cd10f6348ea2b9e17e203b87664 > service/src/java/org/apache/hive/service/cli/SessionHandle.java 52e0ad4834d8b44d5038bb5c1a851eb702cd38ca > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 50c912ee606bce73f447fba69ce0f57d8c7fc6c9 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java 637cdca3bcea9d320f397de032fd78d59ce6afef > service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java 529eaa45d29d22e0e80ea2c08a27b84f2909eda3 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8434965e87366e86d27685c5ca70ee904446bae9 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 1af45398b895cd7616c5627d318422e14b81e734 > service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171 > > Diff: https://reviews.apache.org/r/41928/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > > --===============3701805385522064245==--