Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B979D183BF for ; Tue, 5 Jan 2016 01:21:47 +0000 (UTC) Received: (qmail 36823 invoked by uid 500); 5 Jan 2016 01:21:47 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 36735 invoked by uid 500); 5 Jan 2016 01:21:47 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 36718 invoked by uid 99); 5 Jan 2016 01:21:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 01:21:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9F542297D68; Tue, 5 Jan 2016 01:21:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4789088928350395894==" MIME-Version: 1.0 Subject: Re: Review Request 41482: StatsSetupConst.COLUMN_STATS_ACCURATE is not used correctly From: "Ashutosh Chauhan" To: "Ashutosh Chauhan" Cc: "pengcheng xiong" , "hive" Date: Tue, 05 Jan 2016 01:21:45 -0000 Message-ID: <20160105012145.26044.51469@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ashutosh Chauhan" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41482/ X-Sender: "Ashutosh Chauhan" References: <20151223182409.25862.22451@reviews.apache.org> In-Reply-To: <20151223182409.25862.22451@reviews.apache.org> Reply-To: "Ashutosh Chauhan" X-ReviewRequest-Repository: hive-git --===============4789088928350395894== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41482/#review112726 ----------------------------------------------------------- common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java (line 128) This one is better named as BASIC_STATS metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java (line 239) Now that we have flag about state of stats, we need not to reset the value. Just capturing the state is better. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java (line 362) Now that we have flag about state of stats, we need not to reset the value. Just capturing the state is better. ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 4263) We should remove this. We have recorded that stats are invalid. Leaving old stale stats might be better here. Setting them to 0, doesnt look useful. ql/src/test/results/clientpositive/alter_file_format.q.out (lines 67 - 68) Having -1 as numRows or rawDS is not useful. Either we should just remove this stats altogether if we can't know for sure, whats the state of stats is or we can leave the stale stats with stats flag set to false. - Ashutosh Chauhan On Dec. 23, 2015, 6:22 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41482/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 6:22 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-12661 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 2ff76ee > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 432f7d0 > ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java f6fbe74 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 30cae88 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 29df4f9 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java d2a5948 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 03c1c3f > ql/src/test/queries/clientpositive/columnStatsUpdateForStatsOptimizer.q PRE-CREATION > ql/src/test/results/clientnegative/stats_partialscan_autogether.q.out d03c249 > ql/src/test/results/clientnegative/unset_table_property.q.out 158ed38 > ql/src/test/results/clientpositive/alter_file_format.q.out c9e88f8 > ql/src/test/results/clientpositive/alter_merge_stats_orc.q.out cefe069 > ql/src/test/results/clientpositive/alter_numbuckets_partitioned_table2_h23.q.out 29a4c4b > ql/src/test/results/clientpositive/alter_numbuckets_partitioned_table_h23.q.out 4d0f841 > ql/src/test/results/clientpositive/alter_partition_clusterby_sortby.q.out f5e8d1f > ql/src/test/results/clientpositive/alter_partition_coltype.q.out 08bd2b8 > ql/src/test/results/clientpositive/alter_skewed_table.q.out 03904e6 > ql/src/test/results/clientpositive/alter_table_not_sorted.q.out 40974e4 > ql/src/test/results/clientpositive/alter_table_serde2.q.out 3b63e7d > ql/src/test/results/clientpositive/analyze_table_null_partition.q.out c7254d1 > ql/src/test/results/clientpositive/auto_join_reordering_values.q.out 91b89d7 > ql/src/test/results/clientpositive/auto_sortmerge_join_1.q.out a48c148 > ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out 206a619 > ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 69ae0bf > ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out fbc500b > ql/src/test/results/clientpositive/auto_sortmerge_join_3.q.out 9ae6861 > ql/src/test/results/clientpositive/auto_sortmerge_join_4.q.out 357bc4c > ql/src/test/results/clientpositive/auto_sortmerge_join_5.q.out b763e52 > ql/src/test/results/clientpositive/auto_sortmerge_join_7.q.out cef3bd3 > ql/src/test/results/clientpositive/auto_sortmerge_join_8.q.out 567e3cf > ql/src/test/results/clientpositive/binary_output_format.q.out 30d0037 > ql/src/test/results/clientpositive/bucket1.q.out 8009514 > ql/src/test/results/clientpositive/bucket2.q.out 75de8a9 > ql/src/test/results/clientpositive/bucket3.q.out c459870 > ql/src/test/results/clientpositive/bucket4.q.out e0e5fa6 > ql/src/test/results/clientpositive/bucket5.q.out c1dd90d > ql/src/test/results/clientpositive/bucket_many.q.out 04ec255 > ql/src/test/results/clientpositive/bucket_map_join_1.q.out c7a8a20 > ql/src/test/results/clientpositive/bucket_map_join_2.q.out 3c3793f > ql/src/test/results/clientpositive/bucket_map_join_spark1.q.out 8411a9b > ql/src/test/results/clientpositive/bucket_map_join_spark2.q.out 008d57a > ql/src/test/results/clientpositive/bucket_map_join_spark3.q.out d5ca1ad > ql/src/test/results/clientpositive/bucket_map_join_spark4.q.out 42abaa3 > ql/src/test/results/clientpositive/bucketcontext_1.q.out d28e582 > ql/src/test/results/clientpositive/bucketcontext_2.q.out 9f92030 > ql/src/test/results/clientpositive/bucketcontext_3.q.out 5a847f0 > ql/src/test/results/clientpositive/bucketcontext_4.q.out 19ed7f9 > ql/src/test/results/clientpositive/bucketcontext_5.q.out e1a911b > ql/src/test/results/clientpositive/bucketcontext_6.q.out 0d3bf6e > ql/src/test/results/clientpositive/bucketcontext_7.q.out 15f1335 > ql/src/test/results/clientpositive/bucketcontext_8.q.out 25d0c3c > ql/src/test/results/clientpositive/bucketmapjoin1.q.out 8999fe6 > ql/src/test/results/clientpositive/bucketmapjoin10.q.out ec6069f > ql/src/test/results/clientpositive/bucketmapjoin11.q.out 15be0af > ql/src/test/results/clientpositive/bucketmapjoin12.q.out b87685c > ql/src/test/results/clientpositive/bucketmapjoin13.q.out cdb7637 > ql/src/test/results/clientpositive/bucketmapjoin2.q.out fb0e601 > ql/src/test/results/clientpositive/bucketmapjoin3.q.out e71c5e1 > ql/src/test/results/clientpositive/bucketmapjoin4.q.out 7dd2202 > ql/src/test/results/clientpositive/bucketmapjoin5.q.out 15969db > ql/src/test/results/clientpositive/bucketmapjoin7.q.out e845006 > ql/src/test/results/clientpositive/bucketmapjoin8.q.out 0ef69ea > ql/src/test/results/clientpositive/bucketmapjoin9.q.out 02c5153 > ql/src/test/results/clientpositive/bucketmapjoin_negative.q.out 124ccb3 > ql/src/test/results/clientpositive/bucketmapjoin_negative2.q.out 03d95a9 > ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out b2b6d01 > ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.java1.7.out 6be2546 > ql/src/test/results/clientpositive/columnStatsUpdateForStatsOptimizer.q.out PRE-CREATION > ql/src/test/results/clientpositive/columnstats_partlvl.q.out 7c57c3c > ql/src/test/results/clientpositive/columnstats_tbllvl.q.out 693bb10 > ql/src/test/results/clientpositive/combine2.q.out 864b7b4 > ql/src/test/results/clientpositive/constantPropagateForSubQuery.q.out bb23263 > ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out a5df511 > ql/src/test/results/clientpositive/create_like.q.out a373178 > ql/src/test/results/clientpositive/ctas.q.out cb8a5c8 > ql/src/test/results/clientpositive/ctas_colname.q.out d5ac6c0 > ql/src/test/results/clientpositive/ctas_uses_database_location.q.out 554ae48 > ql/src/test/results/clientpositive/decimal_serde.q.out 0783d9a > ql/src/test/results/clientpositive/describe_comment_nonascii.q.out b202e65 > ql/src/test/results/clientpositive/describe_table.q.out 4d9d74e > ql/src/test/results/clientpositive/disable_merge_for_bucketing.q.out c75d396 > ql/src/test/results/clientpositive/display_colstats_tbllvl.q.out d78f75c > ql/src/test/results/clientpositive/dynamic_partition_skip_default.q.out a209ae9 > ql/src/test/results/clientpositive/dynpart_sort_opt_vectorization.q.out 6aa270d > ql/src/test/results/clientpositive/dynpart_sort_optimization.q.out 624f970 > ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 > ql/src/test/results/clientpositive/encrypted/encryption_insert_partition_dynamic.q.out 3564e84 > ql/src/test/results/clientpositive/encrypted/encryption_join_unencrypted_tbl.q.out 36a7503 > ql/src/test/results/clientpositive/extrapolate_part_stats_full.q.out 015be29 > ql/src/test/results/clientpositive/extrapolate_part_stats_partial.q.out 2a78ec3 > ql/src/test/results/clientpositive/extrapolate_part_stats_partial_ndv.q.out a4a11d9 > ql/src/test/results/clientpositive/filter_join_breaktask.q.out 13d17aa > ql/src/test/results/clientpositive/fouter_join_ppr.q.out f701122 > ql/src/test/results/clientpositive/groupby_map_ppr.q.out 51780f5 > ql/src/test/results/clientpositive/groupby_map_ppr_multi_distinct.q.out ae79b9b > ql/src/test/results/clientpositive/groupby_ppr.q.out 393633c > ql/src/test/results/clientpositive/groupby_ppr_multi_distinct.q.out 6eb3f66 > ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 > ql/src/test/results/clientpositive/groupby_sort_6.q.out 0169430 > ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de > ql/src/test/results/clientpositive/infer_bucket_sort.q.out 1e584e0 > ql/src/test/results/clientpositive/infer_bucket_sort_bucketed_table.q.out 5573c0a > ql/src/test/results/clientpositive/infer_bucket_sort_convert_join.q.out d1a6789 > ql/src/test/results/clientpositive/infer_bucket_sort_dyn_part.q.out 8beed5f > ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out a621be8 > ql/src/test/results/clientpositive/infer_bucket_sort_list_bucket.q.out 40c2bf3 > ql/src/test/results/clientpositive/infer_bucket_sort_map_operators.q.out 325ed2c > ql/src/test/results/clientpositive/infer_bucket_sort_merge.q.out 3fdc66e > ql/src/test/results/clientpositive/infer_bucket_sort_multi_insert.q.out 523c105 > ql/src/test/results/clientpositive/infer_bucket_sort_num_buckets.q.out b9aa2eb > ql/src/test/results/clientpositive/infer_bucket_sort_reducers_power_two.q.out 558a688 > ql/src/test/results/clientpositive/input23.q.out 4537f3e > ql/src/test/results/clientpositive/input42.q.out 2974159 > ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e > ql/src/test/results/clientpositive/input_part2.q.out ba59f57 > ql/src/test/results/clientpositive/input_part7.q.out 4bf2a11 > ql/src/test/results/clientpositive/input_part9.q.out 0fbdb89 > ql/src/test/results/clientpositive/join17.q.out bbd6a19 > ql/src/test/results/clientpositive/join26.q.out f26ae97 > ql/src/test/results/clientpositive/join32.q.out 13f10f7 > ql/src/test/results/clientpositive/join32_lessSize.q.out 355ad13 > ql/src/test/results/clientpositive/join33.q.out 13f10f7 > ql/src/test/results/clientpositive/join34.q.out 795dd3a > ql/src/test/results/clientpositive/join35.q.out c523154 > ql/src/test/results/clientpositive/join9.q.out 2ffc8f1 > ql/src/test/results/clientpositive/join_filters_overlap.q.out 1d04f37 > ql/src/test/results/clientpositive/join_map_ppr.q.out 4247a2f > ql/src/test/results/clientpositive/lb_fs_stats.q.out e09c406 > ql/src/test/results/clientpositive/list_bucket_dml_1.q.out 067ac5d > ql/src/test/results/clientpositive/list_bucket_dml_10.q.java1.7.out e1f60a8 > ql/src/test/results/clientpositive/list_bucket_dml_11.q.java1.7.out 8cc1370 > ql/src/test/results/clientpositive/list_bucket_dml_12.q.java1.7.out b0735a3 > ql/src/test/results/clientpositive/list_bucket_dml_13.q.java1.7.out 6761092 > ql/src/test/results/clientpositive/list_bucket_dml_14.q.out e9bf8fc > ql/src/test/results/clientpositive/list_bucket_dml_2.q.java1.7.out 59bb498 > ql/src/test/results/clientpositive/list_bucket_dml_3.q.out fad6cb9 > ql/src/test/results/clientpositive/list_bucket_dml_4.q.java1.7.out 23d6896 > ql/src/test/results/clientpositive/list_bucket_dml_5.q.java1.7.out ce8bb4a > ql/src/test/results/clientpositive/list_bucket_dml_6.q.java1.7.out c3ede05 > ql/src/test/results/clientpositive/list_bucket_dml_7.q.out 7bf4a21 > ql/src/test/results/clientpositive/list_bucket_dml_8.q.java1.7.out fc22118 > ql/src/test/results/clientpositive/list_bucket_dml_9.q.java1.7.out 8975ec0 > ql/src/test/results/clientpositive/list_bucket_query_multiskew_1.q.out 7c4b70c > ql/src/test/results/clientpositive/list_bucket_query_multiskew_2.q.out 7f32108 > ql/src/test/results/clientpositive/list_bucket_query_multiskew_3.q.out 4a41abc > ql/src/test/results/clientpositive/list_bucket_query_oneskew_1.q.out bec4f6a > ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out be77ba8 > ql/src/test/results/clientpositive/list_bucket_query_oneskew_3.q.out bef079b > ql/src/test/results/clientpositive/llap/tez_fsstat.q.out 50666a9 > ql/src/test/results/clientpositive/llap/tez_join_result_complex.q.out cbd077f > ql/src/test/results/clientpositive/load_dyn_part8.q.out 073cf5b > ql/src/test/results/clientpositive/louter_join_ppr.q.out 1f685ae > ql/src/test/results/clientpositive/mapjoin_mapjoin.q.out 416634b > ql/src/test/results/clientpositive/merge3.q.out 876fa90 > ql/src/test/results/clientpositive/nullformatCTAS.q.out d6b22b1 > ql/src/test/results/clientpositive/offset_limit_global_optimizer.q.out 999c5e6 > ql/src/test/results/clientpositive/optimize_nullscan.q.out de85410 > ql/src/test/results/clientpositive/orc_analyze.q.out 1156feb > ql/src/test/results/clientpositive/outer_join_ppr.q.java1.7.out 66d1fb3 > ql/src/test/results/clientpositive/parallel_orderby.q.out 8ca536e > ql/src/test/results/clientpositive/parquet_mixed_partition_formats.q.out a412350 > ql/src/test/results/clientpositive/parquet_serde.q.out fb2344a > ql/src/test/results/clientpositive/partition_coltype_literals.q.out 03cd036 > ql/src/test/results/clientpositive/pcr.q.out 617ca8d > ql/src/test/results/clientpositive/pcs.q.out 5cf0dff > ql/src/test/results/clientpositive/pointlookup2.q.out a442425 > ql/src/test/results/clientpositive/pointlookup3.q.out 6a8039f > ql/src/test/results/clientpositive/pointlookup4.q.out 157aea6 > ql/src/test/results/clientpositive/ppd_join_filter.q.out e3b19d4 > ql/src/test/results/clientpositive/ppd_union_view.q.out ba51cbd > ql/src/test/results/clientpositive/ppd_vc.q.out d2889ae > ql/src/test/results/clientpositive/ppr_allchildsarenull.q.out eeae21a > ql/src/test/results/clientpositive/push_or.q.out c8edb65 > ql/src/test/results/clientpositive/rand_partitionpruner1.q.out 3d8e9b8 > ql/src/test/results/clientpositive/rand_partitionpruner2.q.out 88edd07 > ql/src/test/results/clientpositive/rand_partitionpruner3.q.out 634e171 > ql/src/test/results/clientpositive/rcfile_default_format.q.out ee58509 > ql/src/test/results/clientpositive/reduce_deduplicate.q.out f99b25a > ql/src/test/results/clientpositive/regexp_extract.q.out f69f831 > ql/src/test/results/clientpositive/router_join_ppr.q.out b486f21 > ql/src/test/results/clientpositive/sample1.q.out 638cf91 > ql/src/test/results/clientpositive/sample10.q.out d6f1cda > ql/src/test/results/clientpositive/sample2.q.out 9af5731 > ql/src/test/results/clientpositive/sample4.q.out e81abee > ql/src/test/results/clientpositive/sample5.q.out 411fc99 > ql/src/test/results/clientpositive/sample6.q.out 26f7aef > ql/src/test/results/clientpositive/sample7.q.out d737acf > ql/src/test/results/clientpositive/sample8.q.out 8fccf53 > ql/src/test/results/clientpositive/sample9.q.out 2b4acc2 > ql/src/test/results/clientpositive/serde_user_properties.q.out 82a43ae > ql/src/test/results/clientpositive/show_create_table_alter.q.out ddb4c27 > ql/src/test/results/clientpositive/show_create_table_serde.q.out a794bcc > ql/src/test/results/clientpositive/show_tblproperties.q.out c206c60 > ql/src/test/results/clientpositive/smb_mapjoin_11.q.out 8b76fa3 > ql/src/test/results/clientpositive/smb_mapjoin_12.q.out 0dba8e5 > ql/src/test/results/clientpositive/smb_mapjoin_13.q.out 2f6bd2a > ql/src/test/results/clientpositive/smb_mapjoin_15.q.out 55af7fa > ql/src/test/results/clientpositive/sort_merge_join_desc_5.q.out fd16246 > ql/src/test/results/clientpositive/sort_merge_join_desc_6.q.out d66f45a > ql/src/test/results/clientpositive/sort_merge_join_desc_7.q.out f737de1 > ql/src/test/results/clientpositive/spark/alter_merge_stats_orc.q.out cefe069 > ql/src/test/results/clientpositive/spark/auto_join_reordering_values.q.out 250c1ef > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_1.q.out fb9ba66 > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out 4b6affc > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_2.q.out 0ce5e04 > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_3.q.out 4868417 > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_4.q.out 3d00fd9 > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_5.q.out 84527cd > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_7.q.out 39d085d > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_8.q.out 15efeb7 > ql/src/test/results/clientpositive/spark/bucket2.q.out 8bb53d5 > ql/src/test/results/clientpositive/spark/bucket3.q.out b25ea05 > ql/src/test/results/clientpositive/spark/bucket4.q.out 2ad59da > ql/src/test/results/clientpositive/spark/bucket5.q.out a72db3b > ql/src/test/results/clientpositive/spark/bucket_map_join_1.q.out c1b13aa > ql/src/test/results/clientpositive/spark/bucket_map_join_2.q.out 580e098 > ql/src/test/results/clientpositive/spark/bucket_map_join_spark1.q.out e162f4a > ql/src/test/results/clientpositive/spark/bucket_map_join_spark2.q.out 58903d7 > ql/src/test/results/clientpositive/spark/bucket_map_join_spark3.q.out 60ce126 > ql/src/test/results/clientpositive/spark/bucket_map_join_spark4.q.out 338384f > ql/src/test/results/clientpositive/spark/bucketmapjoin1.q.out eb1109d > ql/src/test/results/clientpositive/spark/bucketmapjoin10.q.out fb0c851 > ql/src/test/results/clientpositive/spark/bucketmapjoin11.q.out c761cc5 > ql/src/test/results/clientpositive/spark/bucketmapjoin12.q.out b1cf619 > ql/src/test/results/clientpositive/spark/bucketmapjoin13.q.out efb7198 > ql/src/test/results/clientpositive/spark/bucketmapjoin2.q.out b833522 > ql/src/test/results/clientpositive/spark/bucketmapjoin3.q.out 7b3e66f > ql/src/test/results/clientpositive/spark/bucketmapjoin4.q.out 72e8258 > ql/src/test/results/clientpositive/spark/bucketmapjoin5.q.out 05f2512 > ql/src/test/results/clientpositive/spark/bucketmapjoin7.q.out 3d5fb96 > ql/src/test/results/clientpositive/spark/bucketmapjoin8.q.out c1a5e29 > ql/src/test/results/clientpositive/spark/bucketmapjoin9.q.out 8fb3978 > ql/src/test/results/clientpositive/spark/bucketmapjoin_negative.q.out b6b96a3 > ql/src/test/results/clientpositive/spark/bucketmapjoin_negative2.q.out 1ee2775 > ql/src/test/results/clientpositive/spark/bucketmapjoin_negative3.q.out 3f9f8a5 > ql/src/test/results/clientpositive/spark/ctas.q.out 1ba74aa > ql/src/test/results/clientpositive/spark/disable_merge_for_bucketing.q.out d39c5be > ql/src/test/results/clientpositive/spark/filter_join_breaktask.q.out 74742b2 > ql/src/test/results/clientpositive/spark/groupby_map_ppr.q.out 8a26e81 > ql/src/test/results/clientpositive/spark/groupby_map_ppr_multi_distinct.q.out 6005381 > ql/src/test/results/clientpositive/spark/groupby_ppr.q.out e00d234 > ql/src/test/results/clientpositive/spark/groupby_ppr_multi_distinct.q.out ef1cba2 > ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 > ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 8370bbe > ql/src/test/results/clientpositive/spark/infer_bucket_sort_bucketed_table.q.out 5573c0a > ql/src/test/results/clientpositive/spark/infer_bucket_sort_map_operators.q.out 57a6d59 > ql/src/test/results/clientpositive/spark/infer_bucket_sort_merge.q.out 4db9e35 > ql/src/test/results/clientpositive/spark/infer_bucket_sort_num_buckets.q.out b9dc290 > ql/src/test/results/clientpositive/spark/infer_bucket_sort_reducers_power_two.q.out 15e75bb > ql/src/test/results/clientpositive/spark/input_part2.q.out 9dbde7d > ql/src/test/results/clientpositive/spark/join17.q.out 4b6e596 > ql/src/test/results/clientpositive/spark/join26.q.out 4b68465 > ql/src/test/results/clientpositive/spark/join32.q.out 400639f > ql/src/test/results/clientpositive/spark/join32_lessSize.q.out f761de6 > ql/src/test/results/clientpositive/spark/join33.q.out 400639f > ql/src/test/results/clientpositive/spark/join34.q.out 0f2c413 > ql/src/test/results/clientpositive/spark/join35.q.out 0519689 > ql/src/test/results/clientpositive/spark/join9.q.out c5ee48d > ql/src/test/results/clientpositive/spark/join_filters_overlap.q.out 7ac16d0 > ql/src/test/results/clientpositive/spark/join_map_ppr.q.out adbda97 > ql/src/test/results/clientpositive/spark/list_bucket_dml_10.q.java1.7.out 2f84758 > ql/src/test/results/clientpositive/spark/list_bucket_dml_2.q.java1.7.out f60add4 > ql/src/test/results/clientpositive/spark/load_dyn_part8.q.out 0adeabe > ql/src/test/results/clientpositive/spark/louter_join_ppr.q.out c22158c > ql/src/test/results/clientpositive/spark/mapjoin_mapjoin.q.out 26c8958 > ql/src/test/results/clientpositive/spark/optimize_nullscan.q.out e27a40d > ql/src/test/results/clientpositive/spark/outer_join_ppr.q.java1.7.out 7ac6bf8 > ql/src/test/results/clientpositive/spark/parallel_orderby.q.out 308b82c > ql/src/test/results/clientpositive/spark/pcr.q.out aec8433 > ql/src/test/results/clientpositive/spark/ppd_join_filter.q.out fd2d590 > ql/src/test/results/clientpositive/spark/reduce_deduplicate.q.out b4274fb > ql/src/test/results/clientpositive/spark/router_join_ppr.q.out 620e5d2 > ql/src/test/results/clientpositive/spark/sample1.q.out 6c4f1a8 > ql/src/test/results/clientpositive/spark/sample10.q.out 24cd7fc > ql/src/test/results/clientpositive/spark/sample2.q.out d06291c > ql/src/test/results/clientpositive/spark/sample4.q.out ecee494 > ql/src/test/results/clientpositive/spark/sample5.q.out b0cbe38 > ql/src/test/results/clientpositive/spark/sample6.q.out 520712d > ql/src/test/results/clientpositive/spark/sample7.q.out 673984b > ql/src/test/results/clientpositive/spark/sample8.q.out d17e264 > ql/src/test/results/clientpositive/spark/smb_mapjoin_11.q.out 3210484 > ql/src/test/results/clientpositive/spark/smb_mapjoin_12.q.out 03cf8a3 > ql/src/test/results/clientpositive/spark/smb_mapjoin_13.q.out 44643e4 > ql/src/test/results/clientpositive/spark/smb_mapjoin_15.q.out a98eac8 > ql/src/test/results/clientpositive/spark/stats0.q.out f588ff3 > ql/src/test/results/clientpositive/spark/stats1.q.out ab1f993 > ql/src/test/results/clientpositive/spark/stats10.q.out 9c5090f > ql/src/test/results/clientpositive/spark/stats12.q.out 4a5f075 > ql/src/test/results/clientpositive/spark/stats13.q.out 452d4bc > ql/src/test/results/clientpositive/spark/stats14.q.out f34720d > ql/src/test/results/clientpositive/spark/stats15.q.out aad2e3a > ql/src/test/results/clientpositive/spark/stats16.q.out 2e3cadb > ql/src/test/results/clientpositive/spark/stats18.q.out a7d6ab8 > ql/src/test/results/clientpositive/spark/stats3.q.out cbd66e5 > ql/src/test/results/clientpositive/spark/stats5.q.out 9748469 > ql/src/test/results/clientpositive/spark/stats6.q.out a387075 > ql/src/test/results/clientpositive/spark/stats7.q.out 0e095fc > ql/src/test/results/clientpositive/spark/stats8.q.out 3f4ed63 > ql/src/test/results/clientpositive/spark/stats9.q.out 70175b2 > ql/src/test/results/clientpositive/spark/stats_noscan_1.q.out 2559492 > ql/src/test/results/clientpositive/spark/stats_noscan_2.q.out 8136c39 > ql/src/test/results/clientpositive/spark/stats_only_null.q.out b54be03 > ql/src/test/results/clientpositive/spark/stats_partscan_1_23.q.out eb0145b > ql/src/test/results/clientpositive/spark/statsfs.q.out 2735f5f > ql/src/test/results/clientpositive/spark/transform_ppr1.q.out 6c649dd > ql/src/test/results/clientpositive/spark/transform_ppr2.q.out eeb5087 > ql/src/test/results/clientpositive/spark/union22.q.out 3c98e09 > ql/src/test/results/clientpositive/spark/union24.q.out 8833693 > ql/src/test/results/clientpositive/spark/union_ppr.q.out 1fcea7a > ql/src/test/results/clientpositive/spark/union_remove_1.q.out dacc8a4 > ql/src/test/results/clientpositive/spark/union_remove_10.q.out d98b388 > ql/src/test/results/clientpositive/spark/union_remove_11.q.out 1e7d5cf > ql/src/test/results/clientpositive/spark/union_remove_12.q.out 8066c14 > ql/src/test/results/clientpositive/spark/union_remove_13.q.out e431cd7 > ql/src/test/results/clientpositive/spark/union_remove_14.q.out 7492b78 > ql/src/test/results/clientpositive/spark/union_remove_19.q.out d57c399 > ql/src/test/results/clientpositive/spark/union_remove_2.q.out d886433 > ql/src/test/results/clientpositive/spark/union_remove_20.q.out 17342ad > ql/src/test/results/clientpositive/spark/union_remove_21.q.out a4af758 > ql/src/test/results/clientpositive/spark/union_remove_22.q.out 5062f76 > ql/src/test/results/clientpositive/spark/union_remove_23.q.out 2d85b6b > ql/src/test/results/clientpositive/spark/union_remove_24.q.out 377a642 > ql/src/test/results/clientpositive/spark/union_remove_25.q.out b771fe9 > ql/src/test/results/clientpositive/spark/union_remove_3.q.out 565b834 > ql/src/test/results/clientpositive/spark/union_remove_4.q.out 134528a > ql/src/test/results/clientpositive/spark/union_remove_5.q.out 908298d > ql/src/test/results/clientpositive/spark/union_remove_7.q.out 6719119 > ql/src/test/results/clientpositive/spark/union_remove_8.q.out b33767c > ql/src/test/results/clientpositive/spark/union_remove_9.q.out e837bd7 > ql/src/test/results/clientpositive/spark/vectorized_ptf.q.out 856733b > ql/src/test/results/clientpositive/stats0.q.out 4218272 > ql/src/test/results/clientpositive/stats1.q.out ac34bbb > ql/src/test/results/clientpositive/stats10.q.out 7824cbd > ql/src/test/results/clientpositive/stats11.q.out 6feacfc > ql/src/test/results/clientpositive/stats12.q.out c6e7c68 > ql/src/test/results/clientpositive/stats13.q.out 7415728 > ql/src/test/results/clientpositive/stats14.q.out f34720d > ql/src/test/results/clientpositive/stats15.q.out aad2e3a > ql/src/test/results/clientpositive/stats16.q.out 2e3cadb > ql/src/test/results/clientpositive/stats18.q.out a7d6ab8 > ql/src/test/results/clientpositive/stats3.q.out cbd66e5 > ql/src/test/results/clientpositive/stats4.q.out 9ced932 > ql/src/test/results/clientpositive/stats5.q.out 23d4e6b > ql/src/test/results/clientpositive/stats6.q.out a387075 > ql/src/test/results/clientpositive/stats7.q.out 7f32764 > ql/src/test/results/clientpositive/stats8.q.out 80dd4e8 > ql/src/test/results/clientpositive/stats9.q.out e00fc80 > ql/src/test/results/clientpositive/stats_empty_partition.q.out c13817e > ql/src/test/results/clientpositive/stats_invalidation.q.out 1bb7dc6 > ql/src/test/results/clientpositive/stats_list_bucket.q.java1.7.out eb0ab90 > ql/src/test/results/clientpositive/stats_noscan_1.q.out 2559492 > ql/src/test/results/clientpositive/stats_noscan_2.q.out 8136c39 > ql/src/test/results/clientpositive/stats_only_null.q.out bb63b77 > ql/src/test/results/clientpositive/stats_partscan_1_23.q.out 2a292fe > ql/src/test/results/clientpositive/statsfs.q.out 2735f5f > ql/src/test/results/clientpositive/temp_table_display_colstats_tbllvl.q.out b139823 > ql/src/test/results/clientpositive/tez/alter_merge_stats_orc.q.out cefe069 > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_1.q.out 95ef7d4 > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_11.q.out 940480b > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_12.q.out 09a10bd > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_2.q.out 3d123c7 > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_3.q.out 51748fd > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_4.q.out bd383d8 > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_5.q.out d4e2d6b > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_7.q.out 989e9fb0 > ql/src/test/results/clientpositive/tez/auto_sortmerge_join_8.q.out b809c74 > ql/src/test/results/clientpositive/tez/bucket2.q.out 55aa220 > ql/src/test/results/clientpositive/tez/bucket3.q.out bbd9c67 > ql/src/test/results/clientpositive/tez/bucket4.q.out ed8671c > ql/src/test/results/clientpositive/tez/ctas.q.out d4fa0ab > ql/src/test/results/clientpositive/tez/disable_merge_for_bucketing.q.out 84e0d2c > ql/src/test/results/clientpositive/tez/dynpart_sort_opt_vectorization.q.out 2f6753a > ql/src/test/results/clientpositive/tez/dynpart_sort_optimization.q.out fbe434c > ql/src/test/results/clientpositive/tez/dynpart_sort_optimization2.q.out 346e52f > ql/src/test/results/clientpositive/tez/filter_join_breaktask.q.out bb0c6f1 > ql/src/test/results/clientpositive/tez/mapjoin_mapjoin.q.out 63b9462 > ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out f907ed7 > ql/src/test/results/clientpositive/tez/orc_analyze.q.out 1156feb > ql/src/test/results/clientpositive/tez/sample1.q.out 7bc668e > ql/src/test/results/clientpositive/tez/stats_noscan_1.q.out 96e0e43 > ql/src/test/results/clientpositive/tez/stats_only_null.q.out 5c7b909 > ql/src/test/results/clientpositive/tez/tez_fsstat.q.out 50666a9 > ql/src/test/results/clientpositive/tez/tez_join_result_complex.q.out 8febda0 > ql/src/test/results/clientpositive/tez/transform_ppr1.q.out 88c273b > ql/src/test/results/clientpositive/tez/transform_ppr2.q.out 04fa2f9 > ql/src/test/results/clientpositive/tez/unionDistinct_1.q.out 2cff3ef > ql/src/test/results/clientpositive/tez/union_fast_stats.q.out 9cb7a84 > ql/src/test/results/clientpositive/tez/vectorized_ptf.q.out 7b4fbaa > ql/src/test/results/clientpositive/transform_ppr1.q.out 1a0f333 > ql/src/test/results/clientpositive/transform_ppr2.q.out f307f94 > ql/src/test/results/clientpositive/truncate_column.q.out 2b99d86 > ql/src/test/results/clientpositive/truncate_column_list_bucket.q.out 5ff6607 > ql/src/test/results/clientpositive/udf_explode.q.out 38c963a > ql/src/test/results/clientpositive/udtf_explode.q.out 05937ab > ql/src/test/results/clientpositive/union22.q.out cf31aff > ql/src/test/results/clientpositive/union24.q.out 3f861ba > ql/src/test/results/clientpositive/unionDistinct_1.q.out 77260a6 > ql/src/test/results/clientpositive/union_fast_stats.q.out 1affbe1 > ql/src/test/results/clientpositive/union_ppr.q.out 08f649e > ql/src/test/results/clientpositive/union_remove_1.q.out 35e4458 > ql/src/test/results/clientpositive/union_remove_10.q.out 2159b7e > ql/src/test/results/clientpositive/union_remove_11.q.out 2ab83dc > ql/src/test/results/clientpositive/union_remove_12.q.out 6722c4f > ql/src/test/results/clientpositive/union_remove_13.q.out 4ab447d > ql/src/test/results/clientpositive/union_remove_14.q.out b02b204 > ql/src/test/results/clientpositive/union_remove_19.q.out c1f688e > ql/src/test/results/clientpositive/union_remove_2.q.out 29e5d6c > ql/src/test/results/clientpositive/union_remove_20.q.out 1da81a7 > ql/src/test/results/clientpositive/union_remove_21.q.out c956940 > ql/src/test/results/clientpositive/union_remove_22.q.out 3f13991 > ql/src/test/results/clientpositive/union_remove_23.q.out af152b4 > ql/src/test/results/clientpositive/union_remove_24.q.out 49086e4 > ql/src/test/results/clientpositive/union_remove_25.q.out c98d4c8 > ql/src/test/results/clientpositive/union_remove_3.q.out 7045a26 > ql/src/test/results/clientpositive/union_remove_4.q.out c545dd4 > ql/src/test/results/clientpositive/union_remove_5.q.out 1308c09 > ql/src/test/results/clientpositive/union_remove_7.q.out 61bef8b > ql/src/test/results/clientpositive/union_remove_8.q.out 62af170 > ql/src/test/results/clientpositive/union_remove_9.q.out c0fc54d > ql/src/test/results/clientpositive/unset_table_view_property.q.out 8249246 > ql/src/test/results/clientpositive/vectorized_ptf.q.out 857d155 > > Diff: https://reviews.apache.org/r/41482/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > > --===============4789088928350395894==--