Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BB795184EB for ; Sun, 3 Jan 2016 00:36:56 +0000 (UTC) Received: (qmail 11872 invoked by uid 500); 3 Jan 2016 00:36:56 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 11781 invoked by uid 500); 3 Jan 2016 00:36:56 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 11761 invoked by uid 99); 3 Jan 2016 00:36:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jan 2016 00:36:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C82FA1CC3EF; Sun, 3 Jan 2016 00:36:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6595189214472697061==" MIME-Version: 1.0 Subject: Re: Review Request 41821: HIVE-12767: Implement table property to address Parquet int96 timestamp bug From: "Sergio Pena" To: "Szehon Ho" , "Reuben Kuhnert" , "Mohammad Islam" , "Ryan Blue" Cc: "hive" , "Sergio Pena" Date: Sun, 03 Jan 2016 00:36:54 -0000 Message-ID: <20160103003654.4181.19950@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sergio Pena" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41821/ X-Sender: "Sergio Pena" References: <20151231002247.4182.92535@reviews.apache.org> In-Reply-To: <20151231002247.4182.92535@reviews.apache.org> Reply-To: "Sergio Pena" X-ReviewRequest-Repository: hive-git --===============6595189214472697061== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41821/ ----------------------------------------------------------- (Updated Jan. 3, 2016, 12:36 a.m.) Review request for hive, Ryan Blue, Mohammad Islam, Reuben Kuhnert, and Szehon Ho. Changes ------- Rebase latest changes from master. Summary (updated) ----------------- HIVE-12767: Implement table property to address Parquet int96 timestamp bug Bugs: HIVE-12767 https://issues.apache.org/jira/browse/HIVE-12767 Repository: hive-git Description ------- The following exit criteria is addressed in this patch: * Hive will read Parquet MR int96 timestamp data and adjust values using a time zone from a table property, if set, or using the local time zone if it is absent. No adjustment will be applied to data written by Impala. * Hive will write Parquet int96 timestamps using a time zone adjustment from the same table property, if set, or using the local time zone if it is absent. This keeps the data in the table consistent. * New tables created by Hive will set the table property to UTC if the global option to set the property for new tables is enabled. * Tables created using CREATE TABLE and CREATE TABLE LIKE FILE will not set the property unless the global setting to do so is enabled. * Tables created using CREATE TABLE LIKE will copy the property of the table that is copied. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 591c0ab097f1f384e287876fc25fd24c09006dfb data/files/impala_int96_timestamp.parq PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ac0ecd9c31c0e84b8c4628c86b0fdab7d1842f28 ql/src/java/org/apache/hadoop/hive/ql/io/parquet/MapredParquetOutputFormat.java bfb48a987ce89a373f3da63c9162546c6eda43a9 ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ETypeConverter.java ec0dd818f688ab92feb46be4fb6040ede5ac756a ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/DataWritableReadSupport.java 53f3b72b790d87a75a7cd1d77d8f011c29c41188 ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetRecordReaderWrapper.java 74a1a82047613189678716f765bfaa9ac39b7618 ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetTableUtils.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java aace48ee7d145d199163286d21e4ee7694140d6f ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/DataWritableWriteSupport.java f4621e5dbb81e8d58c4572c901ec9d1a7ca8c012 ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/DataWritableWriter.java 69272dc41dbc5fe29ab4c98e730b591c28f3a297 ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestDataWritableWriter.java 70491390ba2b90f32ef9963be7b19e57672241f3 ql/src/test/org/apache/hadoop/hive/ql/io/parquet/convert/TestETypeConverter.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampUtils.java ec6def5b9ac5f12e6a7cb24c4f4998a6ca6b4a8e ql/src/test/org/apache/hadoop/hive/ql/io/parquet/timestamp/TestParquetTimestampConverter.java PRE-CREATION ql/src/test/queries/clientpositive/parquet_int96_timestamp.q PRE-CREATION ql/src/test/results/clientpositive/parquet_int96_timestamp.q.out PRE-CREATION Diff: https://reviews.apache.org/r/41821/diff/ Testing ------- Added unit and q-tests: ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestDataWritableWriter.java ql/src/test/org/apache/hadoop/hive/ql/io/parquet/convert/TestETypeConverter.java ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampUtils.java ql/src/test/org/apache/hadoop/hive/ql/io/parquet/timestamp/TestParquetTimestampConverter.java ql/src/test/queries/clientpositive/parquet_int96_timestamp.q Thanks, Sergio Pena --===============6595189214472697061==--