hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szehon Ho <sze...@cloudera.com>
Subject Review Request 42777: HIVE-12550 : Cache and display last N completed queries in HS2 WebUI
Date Tue, 26 Jan 2016 03:07:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42777/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-12550
    https://issues.apache.org/jira/browse/HIVE-12550


Repository: hive-git


Description
-------

Use a Guava 'EvictingQueue' to cache finished SQLOperation info.  Bump up Guava version to
get this.  The information is saved when the SQLOperation is closed.

Also fix a small discrepancy where Elapsed Time (existing field) was comparing against lastAccessTime
, which gets updated whenever state changes and some other places.  Chaged to compare against
operation's start time.


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 97fe7bc 
  pom.xml 2066518 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 75187cf 
  service/src/java/org/apache/hive/service/cli/operation/Operation.java 113eddf 
  service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 92135cd 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java c8a69b9 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperationInfo.java PRE-CREATION

  service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp a91b008 

Diff: https://reviews.apache.org/r/42777/diff/


Testing
-------

Manual testing, with screenshot attached.


Thanks,

Szehon Ho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message