hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan" <hashut...@apache.org>
Subject Re: Review Request 42359: HIVE-12805: CBO: Calcite Operator To Hive Operator (Calcite Return Path): MiniTezCliDriver skewjoin.q failure
Date Wed, 20 Jan 2016 22:18:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42359/#review115499
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java
(line 263)
<https://reviews.apache.org/r/42359/#comment176475>

    Do we really need to find uniqueness of expression?
    Can we do numKeys = joinLeafPredInfo.getJoinExprs(i).size() ?


- Ashutosh Chauhan


On Jan. 19, 2016, 9 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42359/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 9 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-12805 CBO: Calcite Operator To Hive Operator (Calcite Return Path): MiniTezCliDriver
skewjoin.q failure
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java
660f01d 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveInsertExchange4JoinRule.java
d6e3915 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java
5d169a1 
> 
> Diff: https://reviews.apache.org/r/42359/diff/
> 
> 
> Testing
> -------
> 
> Clean precommit
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message