hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddharth Seth" <ss...@apache.org>
Subject Re: Review Request 41377: HIVE-12528 don't start HS2 Tez sessions in a single thread
Date Wed, 20 Jan 2016 20:23:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41377/#review115473
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java (line 145)
<https://reviews.apache.org/r/41377/#comment176452>

    This exception is not propagated anywhere ? In the single thread case - an Exception from
start is propagated upwards (where I'm assuming it is handled to shutdown HiveServer or some
such).
    Thread uncaughtExceptionHandler / Callable with a ThreadPoolExecutor ?



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java (line 206)
<https://reviews.apache.org/r/41377/#comment176450>

    Is this statement still valid ? If not, please delete or modify accordingly.


- Siddharth Seth


On Jan. 4, 2016, 11:12 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41377/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 11:12 p.m.)
> 
> 
> Review request for hive, Gunther Hagleitner and Siddharth Seth.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ffe0d9a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java e8864ae 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 3bfe35a 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java a2791a1 
> 
> Diff: https://reviews.apache.org/r/41377/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message