hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 42281: Upgrade Hive to Calcite 1.6
Date Fri, 15 Jan 2016 23:41:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42281/#review114781
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java (line 903)
<https://reviews.apache.org/r/42281/#comment175622>

    This should return false & not null.
    I agree we don't use this today.



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java (line 155)
<https://reviews.apache.org/r/42281/#comment175623>

    Add a TODO: to handle CorrelationId


- John Pullokkaran


On Jan. 15, 2016, 7:10 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42281/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 7:10 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-12839
> 
> 
> Diffs
> -----
> 
>   pom.xml 848432c 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 4825a61

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java eeec44e

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveAlgorithmsUtil.java
6840418 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDefaultCostModel.java
6669d32 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveOnTezCostModel.java
61a3a64 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveRelMdCost.java 90f6a7e

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java
aae57e6 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveFilter.java
2f8cc7d 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveJoin.java
27b1e76 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
c5376bf 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveSemiJoin.java
3558676 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableScan.java
5788805 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java
070c7ea 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExpandDistinctAggregatesRule.java
7d7631b 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinPushTransitivePredicatesRule.java
703c8c6 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
50e139b 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortJoinReduceRule.java
0af60e8 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortRemoveRule.java
618c717 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortUnionReduceRule.java
0ec8bf1 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/FilterSelectivityEstimator.java
c04060f 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdCollation.java
84fa518 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdDistinctRowCount.java
1220401 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdDistribution.java
b83f240 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdMemory.java
bea5943 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdParallelism.java
2f51d3b 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java
b7244fd 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java
caf8978 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java
a0eb83d 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSize.java 3224039

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java
7c22c33 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java
00f1acb 
>   ql/src/test/results/clientpositive/auto_join12.q.out 8ef3664 
>   ql/src/test/results/clientpositive/auto_join13.q.out fa03d2c 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out d40b165 
>   ql/src/test/results/clientpositive/cbo_const.q.out adc5232 
>   ql/src/test/results/clientpositive/correlationoptimizer10.q.out 6bac698 
>   ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 5e0edbc 
>   ql/src/test/results/clientpositive/infer_bucket_sort.q.out 1e584e0 
>   ql/src/test/results/clientpositive/infer_bucket_sort_reducers_power_two.q.out 558a688

>   ql/src/test/results/clientpositive/join13.q.out 3ccff63 
>   ql/src/test/results/clientpositive/join28.q.out 9aadd28 
>   ql/src/test/results/clientpositive/join32.q.out 13f10f7 
>   ql/src/test/results/clientpositive/join32_lessSize.q.out 355ad13 
>   ql/src/test/results/clientpositive/join33.q.out 13f10f7 
>   ql/src/test/results/clientpositive/join_parse.q.out ab657cc 
>   ql/src/test/results/clientpositive/limit_join_transpose.q.out 759aebb 
>   ql/src/test/results/clientpositive/llap/tez_join_hash.q.out 366fedc 
>   ql/src/test/results/clientpositive/mapjoin_mapjoin.q.out 416634b 
>   ql/src/test/results/clientpositive/mapjoin_subquery.q.out cb6d92d 
>   ql/src/test/results/clientpositive/mergejoins.q.out 9010410 
>   ql/src/test/results/clientpositive/ppd_join3.q.out 0000db1 
>   ql/src/test/results/clientpositive/ppd_outer_join4.q.out 289798c 
>   ql/src/test/results/clientpositive/spark/auto_join13.q.out 97c73f8 
>   ql/src/test/results/clientpositive/spark/auto_join_without_localtask.q.out f055a59

>   ql/src/test/results/clientpositive/spark/join13.q.out 5b38f8c 
>   ql/src/test/results/clientpositive/spark/join28.q.out 548a806 
>   ql/src/test/results/clientpositive/spark/join32.q.out 400639f 
>   ql/src/test/results/clientpositive/spark/join32_lessSize.q.out f761de6 
>   ql/src/test/results/clientpositive/spark/join33.q.out 400639f 
>   ql/src/test/results/clientpositive/spark/mapjoin_subquery.q.out b348472 
>   ql/src/test/results/clientpositive/spark/mergejoins.q.out e687240 
>   ql/src/test/results/clientpositive/spark/ppd_join3.q.out c78d4cb 
>   ql/src/test/results/clientpositive/spark/ppd_outer_join4.q.out 8d08308 
>   ql/src/test/results/clientpositive/tez/explainuser_2.q.out eb7d564 
>   ql/src/test/results/clientpositive/tez/tez_join_hash.q.out 0202def 
>   ql/src/test/results/clientpositive/vector_outer_join3.q.out 3345247 
> 
> Diff: https://reviews.apache.org/r/42281/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message