hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pengcheng xiong" <pxi...@hortonworks.com>
Subject Re: Review Request 42081: HIVE-12788: Setting hive.optimize.union.remove to TRUE will break UNION ALL with aggregate functions
Date Mon, 11 Jan 2016 23:05:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42081/#review113865
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java (line 226)
<https://reviews.apache.org/r/42081/#comment174655>

    The patch looks good to me. +1. Could you put the reason that we discussed before here
so that people will have a better understanding? And also please list the future work to improve
it. Thanks.


- pengcheng xiong


On Jan. 10, 2016, 2:17 p.m., Chaoyu Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42081/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 2:17 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, pengcheng xiong, and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12788
>     https://issues.apache.org/jira/browse/HIVE-12788
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> adds StatsOptimizator support to union with aggregate function. Otherwise, it always
returns one row.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 03c1c3f 
>   ql/src/test/queries/clientpositive/union_remove_26.q PRE-CREATION 
>   ql/src/test/results/clientpositive/union_remove_26.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42081/diff/
> 
> 
> Testing
> -------
> 
> 1. Manual tests for some partitcular cases
> 2. submitted to precommit-tests
> 
> 
> Thanks,
> 
> Chaoyu Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message