hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajat Khandelwal" <rajatgupt...@gmail.com>
Subject Re: Review Request 41928: HIVE-12777: Add capability to restore session
Date Fri, 08 Jan 2016 06:53:20 GMT


> On Jan. 7, 2016, 10:17 a.m., Amareshwari Sriramadasu wrote:
> > service/src/test/org/apache/hive/service/cli/CLIServiceTest.java, line 91
> > <https://reviews.apache.org/r/41928/diff/6/?file=1183899#file1183899line91>
> >
> >     Restoring a closed session? I dont think this should be allowed.
> >     
> >     The test should wrt service restart and restore session.
> 
> Rajat Khandelwal wrote:
>     This test class is abstract, the functionality can't be tested here. Can you suggest
another class where I can add such a test?

Added an abstract `restart` method in the abstract test class. The restore test uses that.
Hope that is enough.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41928/#review113180
-----------------------------------------------------------


On Jan. 8, 2016, 12:22 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41928/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 12:22 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12777
>     https://issues.apache.org/jira/browse/HIVE-12777
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Extensions using Hive session handles should be able to restore the hive session from
the handle. 
> 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> 
> Relevant commit: https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java
de66d9efb1cace9d32174e3020920d5e4002dc85 
>   service/if/TCLIService.thrift baf583fb3ecd4a0ab248540ffb5db57100028968 
>   service/src/java/org/apache/hive/service/cli/CLIService.java adc98098437b2d0429dd2af40d8eaae323fbf3f0

>   service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 3155c238ff688bfea16b0aaeea950599bb659b5b

>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be198c063115a8e90c67b1c2fd910ca8bc6

>   service/src/java/org/apache/hive/service/cli/ICLIService.java c9cc1f4da56f1cd10f6348ea2b9e17e203b87664

>   service/src/java/org/apache/hive/service/cli/SessionHandle.java 52e0ad4834d8b44d5038bb5c1a851eb702cd38ca

>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 50c912ee606bce73f447fba69ce0f57d8c7fc6c9

>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 637cdca3bcea9d320f397de032fd78d59ce6afef

>   service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java
529eaa45d29d22e0e80ea2c08a27b84f2909eda3 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8434965e87366e86d27685c5ca70ee904446bae9

>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 1af45398b895cd7616c5627d318422e14b81e734

>   service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171

> 
> Diff: https://reviews.apache.org/r/41928/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message