hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan" <hashut...@apache.org>
Subject Re: Review Request 41721: MetadataUpdater: provide a mechanism to edit the basic statistics of a table (or a partition)
Date Tue, 05 Jan 2016 01:00:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41721/#review112723
-----------------------------------------------------------



common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java (line 111)
<https://reviews.apache.org/r/41721/#comment173210>

    Its better to pass this info via EnvironmentCxt of metastore api, instead of inside of
table properties.
    
    We can get rid of all these three different flags as well.



ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java (lines 1356 - 1369)
<https://reviews.apache.org/r/41721/#comment173208>

    If user provides any other key, alter table will succeed, but will not do anything. Its
better to be explicitly fail here. That is if user is asking to store anything other numRows
or rawDS, throw exception saying invalid stat key.


- Ashutosh Chauhan


On Dec. 30, 2015, 1:54 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41721/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2015, 1:54 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-12730
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 2ff76ee 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 432f7d0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ac0ecd9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 5e6b606 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 5f14c6b 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 98860c6 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 2dabce2 
>   ql/src/test/queries/clientnegative/updateBasicStats.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/updateBasicStats.q PRE-CREATION 
>   ql/src/test/results/clientnegative/updateBasicStats.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/updateBasicStats.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message