hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin" <ser...@hortonworks.com>
Subject Re: Review Request 41102: HIVE-12597 LLAP - allow using elevator without cache
Date Mon, 04 Jan 2016 22:43:59 GMT


> On Dec. 31, 2015, 10:37 a.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2345-2351
> > <https://reviews.apache.org/r/41102/diff/2/?file=1174214#file1174214line2345>
> >
> >     hive.llap.io.memory.size "must be a multiple of allocator arena size" ... but
what determines the arena size?  The only clue I see is in the description of hive.llap.io.allocator.arena.count.
> >     
> >     Is it somewhere between hive.llap.io.allocator.alloc.min and hive.llap.io.allocator.alloc.max,
or does "arena" refer to something else?
> >     
> >     Since hive.llap.io.memory.size has to be a multiple of the allocator arena size,
being clear about the size specification would be helpful.

Old leftover comment.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41102/#review112384
-----------------------------------------------------------


On Dec. 22, 2015, 2:13 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41102/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 2:13 a.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d2dd9c6 
>   data/conf/hive-site.xml 2a5f891 
>   data/conf/llap/hive-site.xml e3425c8 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java 0c96efa

>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/BufferUsageManager.java PRE-CREATION

>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCache.java b17edb5 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java c2a130a

>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java
8788e15 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java
40cb92d 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java PRE-CREATION

>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleBufferManager.java PRE-CREATION

>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 8e5377f

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 467ab71

>   llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java b38f472

>   llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java
e156eaa 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java
58d2ac8 
>   llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java 6375996

>   llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java 8324b21

>   llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java
d0abfa3 
> 
> Diff: https://reviews.apache.org/r/41102/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message