Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DAE941882C for ; Thu, 24 Dec 2015 00:02:21 +0000 (UTC) Received: (qmail 81370 invoked by uid 500); 24 Dec 2015 00:02:21 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 81286 invoked by uid 500); 24 Dec 2015 00:02:21 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 81269 invoked by uid 99); 24 Dec 2015 00:02:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Dec 2015 00:02:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6990A2960AB; Thu, 24 Dec 2015 00:02:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0964478099284949440==" MIME-Version: 1.0 Subject: Re: Review Request 41431: HIVE-12674 HS2 Tez session lifetime From: "Vikram Dixit Kumaraswamy" To: "Siddharth Seth" , "Vikram Dixit Kumaraswamy" Cc: "hive" , "Sergey Shelukhin" Date: Thu, 24 Dec 2015 00:02:20 -0000 Message-ID: <20151224000220.25862.78679@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Vikram Dixit Kumaraswamy" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41431/ X-Sender: "Vikram Dixit Kumaraswamy" References: <20151223013030.663.24665@reviews.apache.org> In-Reply-To: <20151223013030.663.24665@reviews.apache.org> Reply-To: "Vikram Dixit Kumaraswamy" X-ReviewRequest-Repository: hive-git --===============0964478099284949440== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41431/#review111805 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java (line 120) Need a condition for the restart thread as well. ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java (line 455) All of this looks a bit complicated. I still did not understand why we need to re-check the queue below. I think this can be simplified but now may not be the time for it. ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java (line 459) Don't we need to refresh this session? It looks like the number of sessions in the queue can go down this way. - Vikram Dixit Kumaraswamy On Dec. 23, 2015, 1:30 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41431/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 1:30 a.m.) > > > Review request for hive, Siddharth Seth and Vikram Dixit Kumaraswamy. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d2dd9c6 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 971dac9 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java f6bc19c > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 0d84340 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java e5df2ec > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java c066c7a > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java d55c9fe > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java 11c0325 > > Diff: https://reviews.apache.org/r/41431/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > > --===============0964478099284949440==--