Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 684FB1893A for ; Tue, 8 Dec 2015 22:10:47 +0000 (UTC) Received: (qmail 85535 invoked by uid 500); 8 Dec 2015 22:10:47 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 85455 invoked by uid 500); 8 Dec 2015 22:10:46 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 85431 invoked by uid 99); 8 Dec 2015 22:10:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Dec 2015 22:10:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4CA3E29240D; Tue, 8 Dec 2015 22:10:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5264683931775509782==" MIME-Version: 1.0 Subject: Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos From: "Mohit Sabharwal" To: "Szehon Ho" , "Xuefu Zhang" Cc: "Mohit Sabharwal" , "Jimmy Xiang" , "hive" Date: Tue, 08 Dec 2015 22:10:46 -0000 Message-ID: <20151208221046.1619.63924@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mohit Sabharwal" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41062/ X-Sender: "Mohit Sabharwal" References: <20151208000552.31129.96690@reviews.apache.org> In-Reply-To: <20151208000552.31129.96690@reviews.apache.org> Reply-To: "Mohit Sabharwal" X-ReviewRequest-Repository: hive-git --===============5264683931775509782== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41062/#review109411 ----------------------------------------------------------- common/src/java/org/apache/hive/http/HttpServer.java (line 93) should this be conditional on the cluster itself being kerberized ? i.e. if (UserGroupInformation.isSecurityEnabled()) { } - Mohit Sabharwal On Dec. 8, 2015, 12:05 a.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41062/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 12:05 a.m.) > > > Review request for hive, Szehon Ho and Xuefu Zhang. > > > Bugs: HIVE-12485 > https://issues.apache.org/jira/browse/HIVE-12485 > > > Repository: hive-git > > > Description > ------- > > Added an AuthenticationFilter to secure the HS2 web ui with kerberos > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 > common/src/java/org/apache/hive/http/HttpServer.java 4b0ed68 > service/src/java/org/apache/hive/service/server/HiveServer2.java cad541a > > Diff: https://reviews.apache.org/r/41062/diff/ > > > Testing > ------- > > Manually tested it locally. > > > Thanks, > > Jimmy Xiang > > --===============5264683931775509782==--