Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE4F418F7E for ; Fri, 4 Dec 2015 22:35:28 +0000 (UTC) Received: (qmail 23896 invoked by uid 500); 4 Dec 2015 22:35:22 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 23814 invoked by uid 500); 4 Dec 2015 22:35:22 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 23795 invoked by uid 99); 4 Dec 2015 22:35:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Dec 2015 22:35:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 147B92EA58F; Fri, 4 Dec 2015 22:35:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4382261068163488954==" MIME-Version: 1.0 Subject: Re: Review Request 40948: HIVE-12499 : Add HMS metrics for number of tables and partitions From: "Szehon Ho" To: "Szehon Ho" , "Mohit Sabharwal" , "hive" , "Lenni Kuff" Date: Fri, 04 Dec 2015 22:35:21 -0000 Message-ID: <20151204223521.7624.75280@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Szehon Ho" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40948/ X-Sender: "Szehon Ho" References: <20151204015150.1719.55011@reviews.apache.org> In-Reply-To: <20151204015150.1719.55011@reviews.apache.org> Reply-To: "Szehon Ho" X-ReviewRequest-Repository: hive-git --===============4382261068163488954== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40948/ ----------------------------------------------------------- (Updated Dec. 4, 2015, 10:35 p.m.) Review request for hive. Changes ------- Adds some more test coverage, also fixes to the timer thread (give it a name, make it be able to be turned off). Bugs: HIVE-12499 https://issues.apache.org/jira/browse/HIVE-12499 Repository: hive-git Description ------- Add separate timer thread that polls for count of database, table, partition entries to publish as metrics, the period is configurable. Delay in getting exact number should be ok as this is for monitoring. Implemented for HBase and DB metastores. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java 95e2bcf common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 4d881ba common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java fd420f7 itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMetrics.java f571c7c itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestHBaseMetastoreMetrics.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 00602e1 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1c0ab6d metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 5b36b03 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java 2fb3e8f metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 98e6c75 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 9a1d159 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 8dde0af Diff: https://reviews.apache.org/r/40948/diff/ Testing ------- Added unit tests for HBase and Db metastores. Thanks, Szehon Ho --===============4382261068163488954==--