Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7945118E04 for ; Wed, 2 Dec 2015 02:29:12 +0000 (UTC) Received: (qmail 45249 invoked by uid 500); 2 Dec 2015 02:29:11 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 45168 invoked by uid 500); 2 Dec 2015 02:29:11 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 45151 invoked by uid 99); 2 Dec 2015 02:29:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Dec 2015 02:29:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5A746291816; Wed, 2 Dec 2015 02:29:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3645868361465088830==" MIME-Version: 1.0 Subject: Re: Review Request 40827: HIVE-12491 From: "pengcheng xiong" To: "pengcheng xiong" , j.prasanth.j@gmail.com Cc: "Ashutosh Chauhan" , "hive" Date: Wed, 02 Dec 2015 02:29:11 -0000 Message-ID: <20151202022911.1719.29266@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "pengcheng xiong" X-ReviewGroup: hive X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40827/ X-Sender: "pengcheng xiong" References: <20151201190358.1718.27377@reviews.apache.org> In-Reply-To: <20151201190358.1718.27377@reviews.apache.org> Reply-To: "pengcheng xiong" X-ReviewRequest-Repository: hive-git --===============3645868361465088830== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40827/#review108599 ----------------------------------------------------------- Gooks lood to me. +1 - pengcheng xiong On Dec. 1, 2015, 7:03 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40827/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 7:03 p.m.) > > > Review request for hive, Prasanth_J and pengcheng xiong. > > > Bugs: HIVE-12491 > https://issues.apache.org/jira/browse/HIVE-12491 > > > Repository: hive-git > > > Description > ------- > > Better heuristic for ndv computations of functions. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java a8ff158 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 71ed31c > ql/src/test/results/clientpositive/cbo_rp_auto_join0.q.out 7822ad9 > ql/src/test/results/clientpositive/tez/explainuser_1.q.out a3d1f87 > > Diff: https://reviews.apache.org/r/40827/diff/ > > > Testing > ------- > > Existing tests. > > > Thanks, > > Ashutosh Chauhan > > --===============3645868361465088830==--