hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shinichi Yamashita" <yamashita...@oss.nttdata.co.jp>
Subject Re: Review Request 41723: HIVE-12372: Improve to support the multibyte character at lpad and rpad
Date Tue, 29 Dec 2015 12:45:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41723/
-----------------------------------------------------------

(Updated Dec. 29, 2015, 9:45 p.m.)


Review request for hive.


Changes
-------

Thank you for your review. I changed the patch file.


Bugs: HIVE-12372
    https://issues.apache.org/jira/browse/HIVE-12372


Repository: hive-git


Description
-------

HIVE-12372: Improve to support the multibyte character at lpad and rpad


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java 33839f7 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLpad.java f15a869 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRpad.java b512332 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLpad.java 6344417 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFRpad.java 71ffcb9 

Diff: https://reviews.apache.org/r/41723/diff/


Testing
-------

TestGenericUDFLpad#testLpad
TestGenericUDFRpad#testRpad


Thanks,

Shinichi Yamashita


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message