hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikram Dixit Kumaraswamy" <vikram.di...@gmail.com>
Subject Re: Review Request 41431: HIVE-12674 HS2 Tez session lifetime
Date Thu, 24 Dec 2015 00:02:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41431/#review111805
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java (line 120)
<https://reviews.apache.org/r/41431/#comment172061>

    Need a condition for the restart thread as well.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java (line 455)
<https://reviews.apache.org/r/41431/#comment172083>

    All of this looks a bit complicated. I still did not understand why we need to re-check
the queue below. I think this can be simplified but now may not be the time for it.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java (line 459)
<https://reviews.apache.org/r/41431/#comment172079>

    Don't we need to refresh this session? It looks like the number of sessions in the queue
can go down this way.


- Vikram Dixit Kumaraswamy


On Dec. 23, 2015, 1:30 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41431/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2015, 1:30 a.m.)
> 
> 
> Review request for hive, Siddharth Seth and Vikram Dixit Kumaraswamy.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d2dd9c6 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 971dac9 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java f6bc19c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 0d84340 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java e5df2ec 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java c066c7a 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java d55c9fe 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java 11c0325 
> 
> Diff: https://reviews.apache.org/r/41431/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message