hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin" <ser...@hortonworks.com>
Subject Re: Review Request 41377: HIVE-12528 don't start HS2 Tez sessions in a single thread
Date Mon, 21 Dec 2015 21:37:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41377/#review111539
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java (line 974)
<https://reviews.apache.org/r/41377/#comment171730>

    Added a field comment



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java (line 987)
<https://reviews.apache.org/r/41377/#comment171731>

    The old path would just re-check the file immediately before sleep. This actually adds
an extra wait :) 
    We need to check HDFS anyway, so I think it's faster to go into IOEx path than to wait
in cases where it won't be helpful.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java (line 1025)
<https://reviews.apache.org/r/41377/#comment171732>

    Where? In case of IOEx path above it's checked before every sleep, and after the last
sleep. In case of in-process collision it's checked once before and after sleep.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java (line 1032)
<https://reviews.apache.org/r/41377/#comment171735>

    moved the loop into the method


- Sergey Shelukhin


On Dec. 18, 2015, 10:10 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41377/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 10:10 p.m.)
> 
> 
> Review request for hive, Gunther Hagleitner and Siddharth Seth.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 36e281a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java 6e196e6 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 0d84340 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java e1a8041 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java 11c0325 
> 
> Diff: https://reviews.apache.org/r/41377/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message