hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 40865: Implement/Enable constant related optimization rules in Calcite: enable HiveReduceExpressionsRule to fold constants
Date Sat, 19 Dec 2015 02:13:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40865/#review111344
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java (line
325)
<https://reviews.apache.org/r/40865/#comment171491>

    This is a change in interface.
    Instead of translating a type now we are translating a RexCall.



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java (line
348)
<https://reviews.apache.org/r/40865/#comment171490>

    Why are we looking at operands arguments?


- John Pullokkaran


On Dec. 19, 2015, 12:28 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40865/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2015, 12:28 a.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-11927
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java
336745b 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsRule.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java
425514d 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
3f2267d 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
631a4ca 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java
2825f77 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7c5a43f 
>   ql/src/test/queries/clientpositive/cbo_const.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/constantfolding.q PRE-CREATION 
>   ql/src/test/results/clientpositive/annotate_stats_select.q.out c4d59c8 
>   ql/src/test/results/clientpositive/bucketizedhiveinputformat.q.out 277b0f7 
>   ql/src/test/results/clientpositive/cast1.q.out 0bdecba 
>   ql/src/test/results/clientpositive/cbo_const.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_cross_product_check_2.q.out 62b611b 
>   ql/src/test/results/clientpositive/cbo_rp_lineage2.q.out b14caa8 
>   ql/src/test/results/clientpositive/constantfolding.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cross_product_check_1.q.out e7d6900 
>   ql/src/test/results/clientpositive/cross_product_check_2.q.out df438c9 
>   ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out b85d387 
>   ql/src/test/results/clientpositive/dynpart_sort_optimization2.q.out 24ac550 
>   ql/src/test/results/clientpositive/groupby_ppd.q.out 6164a26 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 7333677 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out e19d1de 
>   ql/src/test/results/clientpositive/input_part1.q.out d6f4d3e 
>   ql/src/test/results/clientpositive/input_part5.q.out f2d7335 
>   ql/src/test/results/clientpositive/input_part6.q.out fa51cdf 
>   ql/src/test/results/clientpositive/lineage2.q.out ec8b76b 
>   ql/src/test/results/clientpositive/lineage3.q.out 747dc9a 
>   ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out be77ba8 
>   ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out 79348f3 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out f6d8388 
>   ql/src/test/results/clientpositive/parquet_predicate_pushdown.q.out b322ef1 
>   ql/src/test/results/clientpositive/partition_multilevels.q.out c1c8778 
>   ql/src/test/results/clientpositive/perf/query31.q.out c479d91 
>   ql/src/test/results/clientpositive/perf/query39.q.out 0ad62cc 
>   ql/src/test/results/clientpositive/perf/query42.q.out a3264c7 
>   ql/src/test/results/clientpositive/perf/query52.q.out ac0c1e6 
>   ql/src/test/results/clientpositive/perf/query64.q.out 9735b45 
>   ql/src/test/results/clientpositive/perf/query66.q.out 42bcb83 
>   ql/src/test/results/clientpositive/perf/query75.q.out 70a1649 
>   ql/src/test/results/clientpositive/pointlookup2.q.out a442425 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 519f647 
>   ql/src/test/results/clientpositive/quotedid_partition.q.out d34a005 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out b5e7846 
>   ql/src/test/results/clientpositive/spark/cross_product_check_1.q.out 5b03dcf 
>   ql/src/test/results/clientpositive/spark/cross_product_check_2.q.out 93c502d 
>   ql/src/test/results/clientpositive/spark/dynamic_rdd_cache.q.out b597ebd 
>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 239e803 
>   ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 8370bbe 
>   ql/src/test/results/clientpositive/spark/union_remove_25.q.out b771fe9 
>   ql/src/test/results/clientpositive/spark/union_view.q.out cce7710 
>   ql/src/test/results/clientpositive/subquery_notin.q.out ed86079 
>   ql/src/test/results/clientpositive/subquery_notin_having.q.java1.7.out 7b7ccda 
>   ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 3241787 
>   ql/src/test/results/clientpositive/tez/bucket_map_join_tez1.q.out 9582334 
>   ql/src/test/results/clientpositive/tez/cross_product_check_1.q.out 0e7c681 
>   ql/src/test/results/clientpositive/tez/cross_product_check_2.q.out efd8b5d 
>   ql/src/test/results/clientpositive/tez/dynpart_sort_optimization2.q.out 346e52f 
>   ql/src/test/results/clientpositive/tez/explainuser_1.q.out c081309 
>   ql/src/test/results/clientpositive/tez/vector_decimal_round.q.out 9a5d047 
>   ql/src/test/results/clientpositive/udf1.q.out dffbccf 
>   ql/src/test/results/clientpositive/udf_10_trims.q.out 2f79723 
>   ql/src/test/results/clientpositive/udf_folder_constants.q.out 3830daf 
>   ql/src/test/results/clientpositive/union_remove_25.q.out c98d4c8 
>   ql/src/test/results/clientpositive/union_view.q.out 66ca51b 
>   ql/src/test/results/clientpositive/vector_decimal_round.q.out 25e5cfa 
> 
> Diff: https://reviews.apache.org/r/40865/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message