hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Takanobu Asanuma" <tasan...@yahoo-corp.jp>
Subject Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results
Date Fri, 18 Dec 2015 07:13:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40867/
-----------------------------------------------------------

(Updated 12月 18, 2015, 7:13 a.m.)


Review request for hive.


Changes
-------

I updated the patch based on Sergey's advice. Main points of modification is adding rows to
rowset immediately after reading the final data.


Repository: hive-git


Description
-------

This is a WIP patch for HIVE-11527

* I added a new configuration whose name is hive.server2.webhdfs.bypass.enabled. The default
is false. When this value is true, clients use the bypass.

* I still have not considered security such as Kerberos and SSL at present.

* I have not implement Statement#setFetchSize for bypass yet.


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b5aee00 
  jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 245c6a3 
  jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 3f9024a 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 3d5f3b5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 1634143 
  service/if/TCLIService.thrift baf583f 
  service/src/gen/thrift/gen-cpp/TCLIService_types.h b078c99 
  service/src/gen/thrift/gen-cpp/TCLIService_types.cpp b852379 
  service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementResp.java
0b9aa0f 
  service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java
c936ada 
  service/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f5 
  service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote e167d5b 
  service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec4 
  service/src/java/org/apache/hive/service/cli/CLIService.java adc9809 
  service/src/java/org/apache/hive/service/cli/operation/Operation.java d2b3f9c 
  service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 92135cd 
  service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java d90dd0d 
  service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d 
  service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 50c912e 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8434965 

Diff: https://reviews.apache.org/r/40867/diff/


Testing
-------

I have tested few simple queries and they worked well. But I think there are some problems
for some queries. I'm going to test more queries and fix bugs. I'm also going to add unit
tests.


Thanks,

Takanobu Asanuma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message