hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 41051: HIVE-12570 : Incorrect error message Expression not in GROUP BY key thrown instead of Invalid function
Date Fri, 11 Dec 2015 23:21:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41051/#review110038
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 537)
<https://reviews.apache.org/r/41051/#comment169791>

    What about Window Functions that is not valid?
    Check gen plan if it handles it correctly.
    If not then that should also be covered.
    
    ex: select average(x) over() from t1;


- John Pullokkaran


On Dec. 7, 2015, 9:11 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41051/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2015, 9:11 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Incorrect error message Expression not in GROUP BY key thrown instead of Invalid function
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java dca3081 
>   ql/src/test/queries/clientnegative/invalid_select_fn.q PRE-CREATION 
>   ql/src/test/results/clientnegative/invalid_select_fn.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41051/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message