hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Review Request 41164: HIVE-12628 : Eliminate flakiness in TestMetrics
Date Wed, 09 Dec 2015 23:57:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41164/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-12628
    https://issues.apache.org/jira/browse/HIVE-12628


Repository: hive-git


Description
-------

Rewrite all the TestMetrics tests to not rely on file metrics-json dumps, which was proving
to be flaky.  Now they will get the json live from the metrics and compare.

While at it, fix TestHiveMetaStorePartitionSpecs failures (non-related) by increasing the
timeout.

Finally, add a 'safety' flag to turn off the blocking metadata metrics count at HMS startup,
in case some user doesn't want it.  It's not related to test failures, but might come in handy.


Diffs
-----

  common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java cba1c5a

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 
  common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java f21b431 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMetrics.java
bbfee1d 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestHBaseMetastoreMetrics.java
b528376 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHs2Metrics.java 873e126

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java fec8ea0 
  metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java
ed1a453 
  ql/pom.xml ee1d46c 
  ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/TestZookeeperLockManager.java 7fcaa22

  service/pom.xml 735891c 
  service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java aaeecbe


Diff: https://reviews.apache.org/r/41164/diff/


Testing
-------


Thanks,

Szehon Ho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message