hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 41062: HIVE-12485 Secure HS2 web UI with kerberos
Date Wed, 09 Dec 2015 04:05:25 GMT


> On Dec. 8, 2015, 10:43 p.m., Szehon Ho wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1861
> > <https://reviews.apache.org/r/41062/diff/1/?file=1155465#file1155465line1861>
> >
> >     We can keep it lower-case to keep it consistent.
> 
> Jimmy Xiang wrote:
>     I thought about this too. We have use.SSL and ssl in other configuration parameters.
I am open to change it to lower-case.

Yea I think we should stick with one (lower-case).  SPNEGO and SSL are already there in the
configuration several times in lower-case.  It may be too late for hive.server2.use.SSL.


- Szehon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41062/#review109419
-----------------------------------------------------------


On Dec. 8, 2015, 12:05 a.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41062/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 12:05 a.m.)
> 
> 
> Review request for hive, Szehon Ho and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12485
>     https://issues.apache.org/jira/browse/HIVE-12485
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added an AuthenticationFilter to secure the HS2 web ui with kerberos
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 
>   common/src/java/org/apache/hive/http/HttpServer.java 4b0ed68 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java cad541a 
> 
> Diff: https://reviews.apache.org/r/41062/diff/
> 
> 
> Testing
> -------
> 
> Manually tested it locally.
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message