hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddharth Seth" <ss...@apache.org>
Subject Re: Review Request 40315: HIVE-12341 LLAP security
Date Tue, 08 Dec 2015 22:22:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40315/#review109407
-----------------------------------------------------------



llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstance.java (line 47)
<https://reviews.apache.org/r/40315/#comment168902>

    rename to  getManagementPort ?



llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemonProtocolServerImpl.java
(line 156)
<https://reviews.apache.org/r/40315/#comment168905>

    Not for this jira. While the daemons serve the management protocol - the management protocol
and daemon protocol could potentially run on the same server with the same port. This saveson
the number of handler threads which end up being created.



llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemonProtocolServerImpl.java
(line 159)
<https://reviews.apache.org/r/40315/#comment168908>

    In the interim - a separate configuration for management handlers would help, which could
be set to a low values - maybe 2.



llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java (line 66)
<https://reviews.apache.org/r/40315/#comment168911>

    New jira to make this configurable


- Siddharth Seth


On Dec. 5, 2015, 9:40 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40315/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2015, 9:40 p.m.)
> 
> 
> Review request for hive, Gopal V and Siddharth Seth.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d52f994 
>   llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapIoProxy.java 4c31e32 
>   llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapProxy.java PRE-CREATION

>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstance.java f116de4

>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java
a085427 
>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java
2673ad7 
>   llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenIdentifier.java
PRE-CREATION 
>   llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenProvider.java PRE-CREATION

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/LlapDaemonProtocolBlockingPB.java
5ad2344 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/LlapManagementProtocolBlockingPB.java
PRE-CREATION 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java dbdf571

>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemonProtocolClientImpl.java
4b13277 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemonProtocolServerImpl.java
784c631 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapManagementProtocolClientImpl.java
PRE-CREATION 
>   llap-server/src/java/org/apache/hadoop/hive/llap/protocol/LlapTaskUmbilicalProtocol.java
fae7654 
>   llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapDaemonPolicyProvider.java
PRE-CREATION 
>   llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java PRE-CREATION

>   llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapServerSecurityInfo.java
PRE-CREATION 
>   llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapTokenSelector.java PRE-CREATION

>   llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java PRE-CREATION

>   llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
b93650d 
>   llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapUmbilicalPolicyProvider.java
PRE-CREATION 
>   llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 8144165

>   llap-server/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo
PRE-CREATION 
>   llap-server/src/main/resources/META-INF/services/org.apache.hadoop.security.token.TokenRenewer
PRE-CREATION 
>   llap-server/src/protobuf/LlapDaemonProtocol.proto 0ba6acf 
>   llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 52ba360

>   llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java
bf8a673 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1a9469a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/GlobalWorkMapFactory.java 7c38dc3 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ObjectCacheFactory.java 3d9771a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java 914b4e7 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java efcf88c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 07f26be 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 3feab1a 
>   serde/src/java/org/apache/hadoop/hive/serde2/AbstractSerDe.java 9269ff4 
> 
> Diff: https://reviews.apache.org/r/40315/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message