hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lenni Kuff" <lsk...@cloudera.com>
Subject Re: Review Request 40948: HIVE-12499 : Add HMS metrics for number of tables and partitions
Date Fri, 04 Dec 2015 07:46:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40948/#review108948
-----------------------------------------------------------



itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMetrics.java
(line 104)
<https://reviews.apache.org/r/40948/#comment168403>

    maybe add a partitioned/unpartitioned table that is in a different database for extra
test coverage



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 414)
<https://reviews.apache.org/r/40948/#comment168401>

    Would it make sense to use a cached-gauge for these operations? 
    
    https://dropwizard.github.io/metrics/3.1.0/manual/core/#cached-gauges



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 5777)
<https://reviews.apache.org/r/40948/#comment168402>

    How expensive is this? What are your thoughts on doing this nce at startup, then increment/decrementing
as individual objects are added/removed?


- Lenni Kuff


On Dec. 4, 2015, 1:51 a.m., Szehon Ho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40948/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 1:51 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12499
>     https://issues.apache.org/jira/browse/HIVE-12499
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Add separate timer thread that polls for count of database, table, partition entries
to publish as metrics, the period is configurable.  Delay in getting exact number should be
ok as this is for monitoring.
> 
> Implemented for HBase and DB metastores.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java 95e2bcf

>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 4d881ba 
>   common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java fd420f7

>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMetrics.java
f571c7c 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestHBaseMetastoreMetrics.java
PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 00602e1 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1c0ab6d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 5b36b03 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java 2fb3e8f

>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 98e6c75 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
9a1d159 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
8dde0af 
> 
> Diff: https://reviews.apache.org/r/40948/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests for HBase and Db metastores.
> 
> 
> Thanks,
> 
> Szehon Ho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message