hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang" <jxi...@apache.org>
Subject Re: Review Request 40833: HIVE-12471 Secure HS2 web UI with SSL
Date Wed, 02 Dec 2015 21:27:31 GMT


> On Dec. 2, 2015, 9:23 p.m., Mohit Sabharwal wrote:
> > The conditional is reverse, otherwise lgtm

Good catch! Will fix. Thanks.


> On Dec. 2, 2015, 9:23 p.m., Mohit Sabharwal wrote:
> > common/src/java/org/apache/hive/http/HttpServer.java, line 286
> > <https://reviews.apache.org/r/40833/diff/2/?file=1151660#file1151660line286>
> >
> >     (!b.useSSL) ?

Fixed.


- Jimmy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40833/#review108725
-----------------------------------------------------------


On Dec. 2, 2015, 8:09 p.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40833/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 8:09 p.m.)
> 
> 
> Review request for hive, Lefty Leverenz, Szehon Ho, and Xuefu Zhang.
> 
> 
> Bugs: HIVE-12471
>     https://issues.apache.org/jira/browse/HIVE-12471
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This patch changed the HttpServer construction to use builder which is flexible. It addes
3 configurations for web UI SSL support. By default, it is disabled.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f96071 
>   common/src/java/org/apache/hive/http/HttpServer.java 1ff8d7c 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 204eb5a 
> 
> Diff: https://reviews.apache.org/r/40833/diff/
> 
> 
> Testing
> -------
> 
> Tested web UI with and without SSL, both work as expected.
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message