hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chaoyu Tang" <>
Subject Re: Review Request 40628: HIVE-12505: Insert overwrite in same encrypted zone silently fails to remove some existing files
Date Wed, 02 Dec 2015 19:49:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 2, 2015, 7:49 p.m.)

Review request for hive.


Thanks Aihua for review. I updated the patch based on our offline discussion

Bugs: HIVE-12505

Repository: hive-git


With HDFS Trash enabled but its encryption zone lower than Hive data directory, insert overwrite
command silently fails to trash the existing files during overwrite, which could lead to unexpected
incorrect results (more rows returned than expected if the destination directory could not
be cleaned completely). This patch changes include:
1. catch trashing failure due to the probable lower Trash encryption zone, and retry with
force delete
2. if the destination directory could not be cleaned, throw exception instead of swallowing

Diffs (updated)

  common/src/java/org/apache/hadoop/hive/common/ f943781 
  itests/src/test/resources/ 0c5140c 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/ 488d923 
  ql/src/test/queries/clientpositive/encryption_with_trash.q PRE-CREATION 
  ql/src/test/results/clientpositive/encrypted/encryption_with_trash.q.out PRE-CREATION 



1. new unit tests passed
2. submitted for precommit test


Chaoyu Tang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message