hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 40589: Implement limit push down through union all in CBO
Date Wed, 02 Dec 2015 18:32:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40589/#review108698
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortUnionReduceRule.java
(line 110)
<https://reviews.apache.org/r/40589/#comment168155>

    what if the previous limit got pushed past project/join due to limitjointranspose rules.
    
    Then this will fire in a loop.
    
    Limit-Union-Proj-Limit


- John Pullokkaran


On Nov. 23, 2015, 5:59 a.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40589/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 5:59 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-11775
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortUnionReduceRule.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java c005b1a 
>   ql/src/test/queries/clientpositive/cbo_SortUnionTransposeRule.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/parquet_ppd_boolean.q 059da68 
>   ql/src/test/queries/clientpositive/parquet_ppd_char.q eaddcb4 
>   ql/src/test/queries/clientpositive/parquet_ppd_date.q 41d0d64 
>   ql/src/test/queries/clientpositive/parquet_ppd_decimal.q dfca486 
>   ql/src/test/queries/clientpositive/parquet_ppd_timestamp.q 1b9f6ff 
>   ql/src/test/queries/clientpositive/parquet_ppd_varchar.q 6449c6d 
>   ql/src/test/results/clientpositive/cbo_SortUnionTransposeRule.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/merge4.q.out 031376f 
>   ql/src/test/results/clientpositive/parquet_ppd_boolean.q.out 6e62ee4 
>   ql/src/test/results/clientpositive/parquet_ppd_char.q.out defaa9d 
>   ql/src/test/results/clientpositive/parquet_ppd_date.q.out 55231e9 
>   ql/src/test/results/clientpositive/parquet_ppd_decimal.q.out a30820e 
>   ql/src/test/results/clientpositive/parquet_ppd_timestamp.q.out 3b3e5b7 
>   ql/src/test/results/clientpositive/parquet_ppd_varchar.q.out 5a62e80 
>   ql/src/test/results/clientpositive/spark/temp_table.q.out 718a8a4 
>   ql/src/test/results/clientpositive/temp_table.q.out a9f2bae 
>   ql/src/test/results/clientpositive/tez/temp_table.q.out 200ccdd 
> 
> Diff: https://reviews.apache.org/r/40589/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message